Add test suite by calufa · Pull Request #66 · vlab-research/fly

calufa · 2021-12-30T00:09:52Z

Ticket: #64

TODO:

document the commands to run the test suite
add coverage reports (i.e. go test -coverprofile)
test single functions
clean go.mod

Add test suite to:

netlify · 2021-12-30T00:10:27Z

✔️ Deploy Preview for vlab-research canceled.

🔨 Explore the source changes: 3d2e20a

🔍 Inspect the deploy log: https://app.netlify.com/sites/vlab-research/deploys/6200a5f6bbee6f0007f427fe

nandanrao · 2021-12-30T16:00:09Z

Couple thoughts:

Let's make sure it's documented
Let's make sure that if it doesn't need a database, it doesn't wait on a database (replybot).
Let's make sure we have a way to do coverage reports (i.e. go test -coverprofile) and test single functions (go test -run) etc.

calufa · 2022-01-07T15:31:16Z

-       ) l USING (userid)`;
+       ) l
+    USING (userid)
+    ORDER BY first_timestamp DESC


This is basically a copy and paste from, #59 (comment)

calufa · 2022-01-07T15:32:10Z

        title: 'New User Title',
+        metadata: '{}',
+        survey_name: "test",
+        translation_conf: '{}',


Fields required by DB schema.

calufa · 2022-01-07T15:36:22Z

      };
      const newUser = await User.create(user);
-
-      newUser.token.should.equal(user.token);


Looks like user.token is not implemented?

calufa · 2022-01-07T15:37:51Z

      newUser.email.should.equal(user.email);
-
-      user.token = 'HxpnYoykme73Jz1c9DdAxPws77GzH9jLqE1wu1piSqJj';
-      const userUpdated = await User.update(user);


Looks like we don't have a User.update() method.

calufa · 2022-01-07T15:39:50Z

      };
      await User.create(user);
      const userFromDb = await User.user(user);
-      userFromDb.token.should.equal(user.token);


Looks like user doesn't contain token.

calufa · 2022-01-07T16:07:00Z

@@ -0,0 +1,2 @@
+ALTER TABLE chatroach.states ADD CONSTRAINT valid_state_json CHECK (state_json ? 'state');


Taken from,

fly/scribble/state_test.go

Lines 36 to 39 in e3adaf3

CONSTRAINT "valid_state_json" CHECK (state_json ? 'state'),

PRIMARY KEY (userid, pageid)

);`

)

calufa · 2022-01-07T16:09:44Z

@@ -0,0 +1,2 @@
+ALTER TABLE chatroach.states ADD CONSTRAINT valid_state_json CHECK (state_json ? 'state');
+ALTER TABLE chatroach.states ADD CONSTRAINT fk_facebook_page_id FOREIGN KEY (pageid) REFERENCES chatroach.credentials(facebook_page_id) ON DELETE CASCADE;


Taken from,

fly/scribble/state_test.go

Line 32 in e3adaf3

pageid VARCHAR NOT NULL NOT NULL REFERENCES credentials(facebook_page_id),

calufa · 2022-01-07T18:11:20Z

-	args := m.Called(id, url)
-	return args.Error(0)
-}
-


This looks like dead code.

calufa · 2022-01-09T02:15:18Z

-	assert.Equal(t, "25", *res[2])
+	assert.Equal(t, "25", *res[0])
+	assert.Equal(t, "true", *res[1])
+	assert.Equal(t, "yes", *res[2])


Strangely, results are returned in a diff order. Is this an ok behavior?

calufa · 2022-01-09T02:15:35Z

-
-	mustExec(t, pool, "drop table responses")
+	assert.Equal(t, "123", *res[0])
+	assert.Equal(t, "baz", *res[2])


Strangely, results are returned in a diff order. Is this an ok behavior?

calufa · 2022-01-09T02:17:52Z

-	assert.Equal(t, "LOL", *res[0])
-	assert.Equal(t, "A", *res[1])
+	assert.Equal(t, "A", *res[0])
+	assert.Equal(t, "LOL", *res[1])


Strangely, results are returned in a diff order. Is this an ok behavior?

calufa · 2022-01-09T03:30:28Z

Alright, just double-check the code. Left some comments.

The only services we didn't add test-suites to are:

dashboard-client
botserver
moviehouse

calufa · 2022-01-09T03:34:07Z

For test coverage on services written in go, we are now printing the coverage at the beginning of each test-suite run, and it looks something like this:

... 
Running tests...
[nodemon] 2.0.15
[nodemon] to restart at any time, enter `rs`
[nodemon] watching path(s): *.*
[nodemon] watching extensions: (all)
[nodemon] starting `go test -cover -tags dynamic`
PASS
coverage: 86.4% of statements <--------------------------

Use bash trap

calufa force-pushed the feature/add-unit-test-suite branch from 29fc243 to 8321468 Compare December 30, 2021 00:11

calufa force-pushed the feature/add-unit-test-suite branch 9 times, most recently from 718f257 to 37b5e7b Compare January 6, 2022 07:59

calufa added 2 commits January 6, 2022 12:39

add test suite

0bd91b0

calculate coverage

c7ebfd9

calufa force-pushed the feature/add-unit-test-suite branch 4 times, most recently from 5caf772 to 4afeb28 Compare January 6, 2022 23:02

use nodemon

acec833

calufa force-pushed the feature/add-unit-test-suite branch from 4afeb28 to acec833 Compare January 6, 2022 23:34

use getConfig()

0ef81f3

calufa force-pushed the feature/add-unit-test-suite branch from b3273c7 to 0ef81f3 Compare January 6, 2022 23:47

calufa commented Jan 7, 2022

View reviewed changes

calufa commented Jan 9, 2022

View reviewed changes

calufa requested a review from nandanrao January 9, 2022 03:34

calufa marked this pull request as ready for review January 9, 2022 03:34

update README

3a63a22

calufa force-pushed the feature/add-unit-test-suite branch from aed15fe to 3a63a22 Compare January 9, 2022 03:39

calufa added 2 commits January 30, 2022 13:58

use trap

4a47548

Merge pull request #77 from vlab-research/feature/use-trap

3d2e20a

Use bash trap

		@@ -0,0 +1,2 @@
		ALTER TABLE chatroach.states ADD CONSTRAINT valid_state_json CHECK (state_json ? 'state');

	CONSTRAINT "valid_state_json" CHECK (state_json ? 'state'),
	PRIMARY KEY (userid, pageid)
	);`
	)

Uh oh!

Conversation

calufa commented Dec 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Dec 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nandanrao commented Dec 30, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calufa Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calufa Jan 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calufa commented Jan 9, 2022

Uh oh!

calufa commented Jan 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

calufa commented Dec 30, 2021 •

edited

Loading

netlify Bot commented Dec 30, 2021 •

edited

Loading

calufa Jan 7, 2022 •

edited

Loading

calufa Jan 9, 2022 •

edited

Loading