Repository navigation
Редизайн страницы входа на Bootstrap + тесты - #14
Merged
Merged
Conversation
vladcheck
force-pushed
the
vladcheck/ui-login
branch
2 times, most recently
from
October 6, 2026 11:24
5e0ff14 to
c111375
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
LoginForm.fxmlна BootstrapFX: панельpanel panel-primary, кнопкаbtn btn-primary btn-block, ошибка —alert alert-danger.LoginFormControllerпереписан под паттерн изdocs/examples/how-to-interact-with-api-from-ui-via-middleware.md: обычныеTextField/PasswordField+errorLabel, клиентская валидация (пустые поля, формат email), вызовAuthService.login(), ошибка сервера — вerrorLabel, успех — переход наResourceList.Program: BootstrapFX-стили подключены глобально, стартовой страницей стала форма входа.pom.xmlдобавленmockito-core 5.23.0(scope test).Тесты
ui.LoginFormControllerTest, TestFX + мокAuthService): 5 тестов — пустые поля, пустой пароль, неверный email (API не вызывается, навигации нет), успешный вход (вызовlogin+ переход наResourceList, ошибка скрыта), ошибка сервера (текст вerrorLabel, навигации нет).ui.LoginIntegrationTest, без моков — реальныйAuthServiceImpl+ApiClient): неверные креды против живого API отклоняются сServiceException. Тест пропускается (assume), если бэкенд наlocalhost:8080недоступен.Проверки
mvn verify: 33 теста, 0 failures (1 skipped — нет бэкенда), spotless и checkstyle чистые.