Repository navigation
fix(пользователи): запрет самодаунгрейда и самоблокировки в форме изменения - #99
Merged
Merged
Conversation
…енения onSave блокирует сохранение, если цель — сам пользователь и роль уходит с ADMIN или активность снимается: текст ошибки, без вызова сервиса, без навигации. Свои имя/email не блокируются. Closes #95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что
В UserUpdateFormController не было RBAC-защиты от самодаунгрейда: админ мог снять себе роль (ADMIN→USER) или активность (enabled=false), хотя самоудаление заблокировано в UserDetailsController.
Решение
Гард в onSave (симметрично запрету самоудаления): если цель — текущий пользователь И (роль уходит с ADMIN ИЛИ активность снимается), показывается текст ошибки, без вызова update, без навигации. Свои имя/email блокировать не надо — вне скоупа.
Проверки
Closes #95