Add missing check for empty tensor#1089
Merged
vladmandic merged 2 commits intovladmandic:masterfrom May 20, 2023
Merged
Conversation
Contributor
Author
|
k-diffusers: crowsonkb/k-diffusion#65 |
Owner
|
chatgpt did a pretty good job :) |
Contributor
Author
I didn't feel like learning the tensorflow API, good to see it knew it well already...ha! |
Owner
|
it didn't actually use any new api's it just rearranged existing code |
Contributor
Author
|
Yes, it was a pretty standard modification as we were blindly calling .min() without checking first if it was safe to do so...between my current job using a language that's arguably an "easier" language than previous, and GPT being available, I have trouble caring enough to trace where something's size is set, be it in code or documentation, when I can ask the robot to do it for me...haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes one issue, the other is in k-diffusers; I'll put a pull in there too. Ran into this with tiled VAE...and I'm lazy so chatgpt did the work for me.