Repository navigation
codegen-orchestrator-1688: Record started_at when a deploy or QA run starts, so the Journey timeline shows their durations - #834
Merged
Conversation
Deploy and QA runs go to RUNNING through POST /api/runs/{id}/start, which
never recorded when they started, so the Journey timeline showed them as
not recorded. The first accepted start now stamps started_at; a repeated
start keeps it and a refused start leaves it unset.
The Journey reader validates every completed QA run's result as a QARunResult, so a QA run completed without one made the service test's journey read fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Candidate commit: 1e04088 (tree 2482442cd2600d31c99bea8c5a5fbe4242fd0452) on pipeline/codegen-orchestrator-1688, base main 97010f4.
Why
Deploy and QA runs record when they start, so the Journey stage timeline shows a duration for every deploy and QA run, not "not recorded". This closes DoD item d5 ("a story records the start and end of each stage ... deploy, each QA run").
How verified
CI runs
Backend Docker-in-Docker Integration Tests,Build Service Image Candidates,Build Worker Base Image Candidates,CI Contract,Detect Changed Services,Fast Checks (Unit Tests),Lint (Ruff),Publish Service Image Release,Publish Worker Base Images,Required CI Gate,Service Image Entrypoint Importson1e04088d24f6; the merge waits for them to pass.Card:
codegen-orchestrator-1688