Repository navigation
codegen-orchestrator-1705: Wake PR CI polling after PR review admission - #845
Merged
Merged
Conversation
SchedulerWakeTarget gains pr_ci. scheduler-pipeline binds one Event to
pr_ci_loop and routes the listener's new target to it, so a hint runs the
unchanged poll_pr_ci_once (poll_merged_prs then poll_ci_failures, each
isolated) early through runtime.periodic_loop's wake path.
POST /stories/{id}/pr_review publishes pr_ci right after its commit and
before the refresh. Refused entries, replays and failed commits publish
nothing; no other Story route gains the sender. The api best-effort
publisher moves from the Run router into src/scheduler_wake.py and both
routers use it.
The scheduler wake service tests share the user/project/repository/Story
setup in _scheduler_wake_service.
The grant-intent service tests override the api Redis client with a fake that only had the stream publish. Their merged-replacement setup walks a Story through pr_review, which now also publishes a pr_ci wake hint on the client's native Pub/Sub, so the fake carries an unsubscribed publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Candidate commit: b56d4c4 on pipeline/codegen-orchestrator-1705 (one commit over main aa5851e), tree 86c661e157227e8ebd9f84b079eebae5f1fd56d7. No commit trailer of any kind.
Why
Run the existing PR/CI sweep promptly when a Story enters PR review, and provide its canonical wake receiver for later GitHub completion hints. Keep the configured 30 s sweep as recovery. This advances (internal ref) d3 groundwork; it does not yet make external CI completion event-driven.
How verified
CI runs
Backend Docker-in-Docker Integration Tests,Build Service Image Candidates,Build Worker Base Image Candidates,CI Contract,Detect Changed Services,Fast Checks (Unit Tests),Lint (Ruff),Publish Service Image Release,Publish Worker Base Images,Required CI Gate,Service Image Entrypoint Importsonb56d4c4287a0; the merge waits for them to pass.Card:
codegen-orchestrator-1705