feat: add Files and Vector Stores APIs with in-tree file search - #34
Draft
franciscojavierarceo wants to merge 3 commits into
Draft
franciscojavierarceo wants to merge 3 commits into
franciscojavierarceo wants to merge 3 commits into
Conversation
franciscojavierarceo
requested review from
bbrowning,
jiahuei,
leseb,
maralbahari,
noobHappylife,
qandrew and
tjtanaa
as code owners
May 28, 2026 16:05
franciscojavierarceo
force-pushed
the
feat/axum-ogx-integration-v2
branch
from
May 28, 2026 17:22
48035cb to
84bb97f
Compare
franciscojavierarceo
marked this pull request as draft
May 28, 2026 18:53
This was referenced May 29, 2026
franciscojavierarceo
force-pushed
the
feat/axum-ogx-integration-v2
branch
13 times, most recently
from
June 4, 2026 03:31
d282b0c to
0ef5f75
Compare
Collaborator
|
@franciscojavierarceo Is this still in-progress or ready for review? Happy to take a look when you're ready — especially interested in how the OGX |
Collaborator
Author
franciscojavierarceo
force-pushed
the
feat/axum-ogx-integration-v2
branch
from
June 11, 2026 14:01
0ef5f75 to
cc71bb1
Compare
10 tasks
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
force-pushed
the
feat/axum-ogx-integration-v2
branch
from
September 10, 2026 21:17
be5f85c to
92970fe
Compare
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This was referenced Sep 11, 2026
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrate with main's
AgentPipelinerefactor (#274). Keep per-round citation evidence in the owned translation context, assemble native file-search items through the typed accumulator slots, and preserve already-public citations during strict JSON/SSE decoding. Regression tests cover citation preservation and lenient done-only file-search items.Stack layer 1 of 7: #34 foundation → #278 pgvector/CI → #280 contextual retrieval/reranking/configuration → #281 streaming Files → #282 store lifecycle/content → #283 durable batches → #284 streaming/SDK compatibility.
Base:
main. Next: #278. Review against the immediate base and land from the bottom of the stack.Adds the OGX file-ingestion and retrieval flow directly to Agentic API. Clients can upload documents, attach them to vector stores, and use the Responses
file_searchbuilt-in tool without running OGX or a Python service.0005_file_search.sql.[files] storage_dirorAGENTIC_FILES_STORAGE_DIR(default$AGENTIC_API_HOME/files). Binary upload/download is independent of ingestion format support. New uploads use generated IDs and bounded, atomic file publication with cancellation/error cleanup. Earlier draft uploads stored inline in SQL remain readable.file_search_calllifecycle events, opt-in results, file citations, public tool-choice selectors, and private stored continuation with the existing Responses executor. Preserves the shell-tool implementation from current main.--features file-search-pdfand requires Rust 1.88 or newer.docs/api/file-search.md. Container deployments need a persistent files volume; replicas sharing a database must also share the files directory. Exact retrieval in this foundation targets small corpora. Indexed retrieval, contextual chunking, query rewriting, neural reranking, and asynchronous batches are developed in the dependent stack; arbitrary OGX provider catalogs remain outside this foundation.Test Plan
Layer-specific implementation verification:
cargo test --workspace --all-features --locked, including filesystem-backed HTTP upload/attach/search/download/delete, binary-file round trips, detachment/store-deletion preserving uploads, semantic retrieval without lexical overlap, failure rollback, pagination, filters, persistence, streaming/blocking tool use, citations, continuation, shell regressions, and OpenAPI schemas.cargo clippy --workspace --all-targets --all-features --locked -- -D warnings, formatting,git diff --check, and all pre-commit hooks.After synchronization with #274: The updated foundation passed 657 core/file-search/stream/shell tests, all-target all-feature workspace clippy, formatting, diff checks, and all-files pre-commit hooks. Scoped review and re-review passed. The combined stack in #284 passed 1,389 workspace tests, 31 PostgreSQL/pgvector tests, and 17 maintained SDK cases, plus the Rust 1.88 all-feature check and all-target workspace clippy. The pipeline integration review is complete. GitHub CI is rerunning for the updated heads; previous green checks apply to the prior revisions.