[CI] Allow testing candidate Vime images - #411
Conversation
Signed-off-by: aoshen02 <aoshen@inferact.ai>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the VIME_CI_IMAGE environment variable to allow specifying a custom Docker image for Buildkite CI jobs, defaulting to vllm/vime:latest. It updates the Python scripts, pipeline configuration, and documentation accordingly. Feedback suggests using os.environ.get("VIME_CI_IMAGE") or "vllm/vime:latest" in gpu_suites.py to ensure that empty string values also fall back to the default image, aligning with the bash fallback behavior in pipeline.yml.
|
|
||
| GPU_QUEUE = "mithril-h100-pool" | ||
| CI_IMAGE = "vllm/vime:latest" | ||
| CI_IMAGE = os.environ.get("VIME_CI_IMAGE", "vllm/vime:latest") |
There was a problem hiding this comment.
In Python, os.environ.get("VIME_CI_IMAGE", "vllm/vime:latest") only falls back to the default if the environment variable is completely unset. If VIME_CI_IMAGE is set to an empty string (e.g., VIME_CI_IMAGE=""), it will return "", which is an invalid image name.
Using os.environ.get("VIME_CI_IMAGE") or "vllm/vime:latest" ensures that both unset and empty values correctly fall back to the default image, matching the bash fallback behavior "$${VIME_CI_IMAGE:-vllm/vime:latest}" used in pipeline.yml.
| CI_IMAGE = os.environ.get("VIME_CI_IMAGE", "vllm/vime:latest") | |
| CI_IMAGE = os.environ.get("VIME_CI_IMAGE") or "vllm/vime:latest" |
Signed-off-by: aoshen02 <aoshen@inferact.ai>
2 participants
Motivation
Image-changing PRs must be tested without publishing unmerged code to
vllm/vime:latest.Changes
VIME_CI_IMAGEoverride shared by the static image-backed CPU job and generated GPU jobs.vllm/vime:latestas the default.Validation
vllm/vime:latest.This is a Vime-native CI change split out of #410; it does not change Slime-synchronized runtime behavior.