Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new weight transport option, modelexpress, allowing Megatron weights to be published through ModelExpress and installed in vLLM. It adds the UpdateWeightFromModelExpress class, CLI arguments, and comprehensive unit tests. The review comments suggest several robustness improvements, including validating required configuration keys, defensively handling potential None values in the configuration, and safely handling cases where metrics might be empty.
Signed-off-by: Hyunjae Woo <hwoo@nvidia.com>
1b8611b to
f2c3657
Compare
|
Hi, It does not need to change the vllm code? |
|
Hi @aoshen02, we use vLLM's Weight Transfer Engine plugin to define our custom extension in our ModelExpress codebase, so we don't need any direct changes in vLLM. Also, when used with existing ModelExpress client in vLLM engine, we also support P2P RDMA fan-out across the rollout engines during weight update or cold-start (due to crash or restart) as well as S3 fallback. We don't have a clean doc yet but here are the recent PRs: |
Forward an explicitly configured refit_checkpoint_max_size_gb to rollout init_info. Preserve the ModelExpress default when omitted and forward null to disable the quota. Document the setting and cover explicit limits and null in updater tests. Signed-off-by: Hyunjae Woo <hwoo@nvidia.com> (cherry picked from commit ee6364f) Signed-off-by: Hyunjae Woo <hwoo@nvidia.com>
|

Summary
This PR adds ModelExpress as a VIME weight-update backend, with initial support for S3-based canonical
delta weight synchronization.
Instead of publishing a complete checkpoint after every training update, the trainer captures an initial
Hugging Face baseline and publishes subsequent policy updates as versioned XOR deltas through
ModelExpress.
flowchart LR T[Megatron trainer] -->|canonical HF weights| MX[ModelExpress trainer client] MX -->|XOR delta artifacts| S3[S3-compatible storage] MX -->|version lifecycle| C[ModelExpress catalog] C --> V[vLLM ModelExpress backend] S3 --> VWhat changed
Configuration
Scope
This initial integration supports S3-compatible object storage and the canonical XOR-delta path.
ModelExpress P2P transfer and Dynamo-specific external rollout integration are outside this PR.
Testing
E2E Validation
Ran Qwen3-30B-A3B on B200 nodes with following setup:
Delta
• Versions: v1–v24, v26–v49
• Mean: 46.68s
• Median: 44.94s
Full HF checkpoint
• Versions: v25
• Mean: 545.56s
• Median: 545.56s