Skip to content

fix(ascend): harden disk delta checkpoint handling - #430

Closed
wangx700 wants to merge 71 commits into
vllm-project:ascendfrom
wangx700:feat/pr413-disk-weight-sync
Closed

wangx700 wants to merge 71 commits into
vllm-project:ascendfrom
wangx700:feat/pr413-disk-weight-sync

fix(ascend): harden disk delta checkpoint handling

8f3ffc9
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Sep 14, 2026 in 1s

DCO

There are 30 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~71 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin feat/pr413-disk-weight-sync

Summary

Commit sha: 429b3d2, Author: Ajinkya, Committer: GitHub; Expected "Ajinkya ajinkyajawale14499@gmail.com", but got "ajinkya-metica ajinkya@metica.com".
Commit sha: 491665d, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: 289ee6d, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: 7198547, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: 5532763, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: 789b1bc, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: 2702eef, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: b929921, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: 36a84ad, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: 3f0b42b, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: 1fc199d, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: f1d3c6b, Author: aoshen02, Committer: GitHub; The sign-off is missing.
Commit sha: e0ca828, Author: B1n_, Committer: GitHub; Can not find "B1n_ 160214624+BreezyB1n@users.noreply.github.com", in ["BreezyB1n 160214624+BreezyB1n@users.noreply.github.com", "BreezyB1n 160214624+BreezyB1n@users.noreply.github.com", "aoshen02 aoshen@inferact.ai", "BreezyB1n 160214624+BreezyB1n@users.noreply.github.com", "aoshen02 aoshen@inferact.ai"].
Commit sha: 8144096, Author: Gianthard-cyh, Committer: GitHub; Expected "Gianthard-cyh 45843411+Gianthard-cyh@users.noreply.github.com", but got "aoshen02 aoshen@inferact.ai".
Commit sha: 3bc70bb, Author: kaiyuanxie, Committer: GitHub; Can not find "kaiyuanxie kyxiezju@163.com", in ["kaiyuan kyxiezju@163.com", "kaiyuan kyxiezju@163.com", "kaiyuan kyxiezju@163.com", "kaiyuan kyxiezju@163.com", "kaiyuan kyxiezju@163.com"].
Commit sha: 69d5fd1, Author: kaiyuanxie, Committer: GitHub; Can not find "kaiyuanxie kyxiezju@163.com", in ["xky kyxiezju@163.com", "xky kyxiezju@163.com", "xky kyxiezju@163.com", "xky kyxiezju@163.com", "xky kyxiezju@163.com"].
Commit sha: e62d44f, Author: kaiyuanxie, Committer: GitHub; Expected "kaiyuanxie kyxiezju@163.com", but got "kaiyuan kyxiezju@163.com".
Commit sha: d679c75, Author: kaiyuanxie, Committer: GitHub; Can not find "kaiyuanxie kyxiezju@163.com", in ["kaiyuan kyxiezju@163.com", "kaiyuan kyxiezju@163.com", "kaiyuan kyxiezju@163.com"].
Commit sha: 8b197ff, Author: kaiyuanxie, Committer: GitHub; Expected "kaiyuanxie kyxiezju@163.com", but got "kaiyuan kyxiezju@163.com".
Commit sha: 5cabf1f, Author: kaiyuanxie, Committer: GitHub; Can not find "kaiyuanxie kyxiezju@163.com", in ["kaiyuan kyxiezju@163.com", "kaiyuan kyxiezju@163.com", "kaiyuan kyxiezju@163.com", "kaiyuan kyxiezju@163.com", "kaiyuan kyxiezju@163.com"].
Commit sha: dfb2775, Author: kaiyuanxie, Committer: GitHub; Can not find "kaiyuanxie kyxiezju@163.com", in ["CalvinXKY xky@users.noreply.github.com", "CalvinXKY xky@users.noreply.github.com", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "CalvinXKY xky@users.noreply.github.com", "aoshen02 aoshen@inferact.ai"].
Commit sha: 4a550b6, Author: Kevin H. Luu, Committer: GitHub; Can not find "Kevin H. Luu khluu000@gmail.com", in ["aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "khluu khluu000@gmail.com", "aoshen02 aoshen@inferact.ai", "khluu khluu000@gmail.com"].
Commit sha: 3af3f3c, Author: meihanc, Committer: GitHub; Can not find "meihanc zr010426ztt@outlook.com", in ["Meihan-chen zr010426ztt@outlook.com", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "Meihan-chen zr010426ztt@outlook.com", "aoshen02 aoshen@inferact.ai"].
Commit sha: edeb3a1, Author: Nguyen Kha Nhat Long, Committer: GitHub; Can not find "Nguyen Kha Nhat Long knlnguyen1802@gmail.com", in ["knlnguyen1802 knlnguyen1802@gmail.com", "knlnguyen1802 knlnguyen1802@gmail.com", "knlnguyen1802 knlnguyen1802@gmail.com", "knlnguyen1802 knlnguyen1802@gmail.com", "knlnguyen1802 knlnguyen1802@gmail.com", "knlnguyen1802 knlnguyen1802@gmail.com", "knlnguyen1802 knlnguyen1802@gmail.com", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "aoshen02 aoshen@inferact.ai", "knlnguyen1802 knlnguyen1802@gmail.com", "aoshen02 aoshen@inferact.ai"].
Commit sha: db6c87d, Author: Salt Sato, Committer: GitHub; Expected "Salt Sato feathbow@gmail.com", but got "Feathbow feathbow@gmail.com".
Commit sha: e70b319, Author: Shekhar, Committer: GitHub; The sign-off is missing.
Commit sha: c0ed6d8, Author: Shekhar, Committer: GitHub; Can not find "Shekhar 38083203+indianspeedster@users.noreply.github.com", in ["indianspeedster cp3793@nyu.edu", "indianspeedster cp3793@nyu.edu", "Shekhar cp3793@nyu.edu", "Shekhar cp3793@nyu.edu", "Shekhar cp3793@nyu.edu", "indianspeedster cp3793@nyu.edu", "Shekhar cp3793@nyu.edu"].
Commit sha: 85ac426, Author: Shekhar, Committer: GitHub; Expected "Shekhar 38083203+indianspeedster@users.noreply.github.com", but got "indianspeedster cspandey016@gmail.com".
Commit sha: 93182da, Author: Shuolei Wang, Committer: GitHub; Can not find "Shuolei Wang 46160365+ShuoleiWang@users.noreply.github.com", in ["Shuolei Wang shuoleiwang123@gmail.com", "aoshen02 aoshen@inferact.ai", "Shuolei Wang shuoleiwang123@gmail.com", "aoshen02 aoshen@inferact.ai"].
Commit sha: 8f3ffc9, Author: wangx700, Committer: wangx700; The sign-off is missing.