[ROCm] cmake: support PYTORCH_FOUND_HIP for torch 2.13 native HIP language support

[nemanjaudovic]

torch 2.13 switched from FindHIP.cmake (legacy) to CMake native enable_language(HIP) in commit pytorch/pytorch@d921fd0. The new approach sets PYTORCH_FOUND_HIP but never sets HIP_FOUND, which caused vllm's CMakeLists.txt to fall through to the fatal error path.

Fix the HIP detection condition in vllm's CMakeLists.txt to also accept PYTORCH_FOUND_HIP.

More details about the problem

Building vllm with PyTorch 2.13 on ROCm fails with:

CMake Error at CMakeLists.txt:169 (message):
  Can't find CUDA or HIP installation.

This happens even when HIP/ROCm is correctly installed and torch itself was built with ROCm support.

Root Cause

PyTorch 2.13 migrated from the legacy FindHIP.cmake module to CMake's native HIP language support (enable_language(HIP)) in pytorch/pytorch@d921fd0. The motivation was Windows support, where FindHIP.cmake's bash-based linker helper doesn't work.

The old LoadHIP.cmake (torch ≤2.12) called find_package(HIP MODULE), which ran FindHIP.cmake and set HIP_FOUND=TRUE as a CMake convention side effect. The new LoadHIP.cmake (torch 2.13) bypasses FindHIP.cmake entirely and sets only
PYTORCH_FOUND_HIP=TRUE.

vllm's CMakeLists.txt checked only HIP_FOUND to detect HIP, which is never set by torch 2.13, causing it to fall through to
the fatal error on line 169.

Fix

Extend the HIP detection condition to also accept PYTORCH_FOUND_HIP, which is set by both torch 2.12 and 2.13:

# Before
if (NOT HIP_FOUND AND CUDA_FOUND)
...
elseif(HIP_FOUND)

# After
if (NOT HIP_FOUND AND NOT PYTORCH_FOUND_HIP AND CUDA_FOUND)
...
elseif(HIP_FOUND OR PYTORCH_FOUND_HIP)

After this fix vllm builds correctly.

[mergify]

Hi @nemanjaudovic, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

[Harry-Chen]

Thanks!

[Harry-Chen]

CC @tjtanaa do you want to take a look?

[tjtanaa]

Looks fine to me that we can compile the code for AMD CI

[nemanjaudovic]

Seems that CI is getting stuck on some unrelated tests