Revert "[Bugfix][CPU] Remove invalid extra deps" (#43977)#44043
Draft
vllm-agent wants to merge 1 commit into
Draft
Revert "[Bugfix][CPU] Remove invalid extra deps" (#43977)#44043vllm-agent wants to merge 1 commit into
vllm-agent wants to merge 1 commit into
Conversation
This reverts commit 3f6f508.
mergify
Bot
added
ci/build
cpu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert of #43977
This reverts commit 3f6f508.
Reason: This PR changed
docker/Dockerfile.cpuandsetup.py, which triggered a full Rust rebuild during CPU Docker image creation. The rebuild exposed a pre-existing compilation error:no method named vllm_version found for reference &vllm_engine_core_client::EngineCoreClientinrust/src/server/src/routes/version.rs(introduced by PR #43854).Impact: 2 CPU test suites failed in nightly build #68973:
Note: The root cause is a missing
vllm_version()method onEngineCoreClient(from PR #43854), but reverting this PR restores the cached Docker layer that avoids the Rust rebuild. A proper fix should add the missing method to the Rust client before re-landing this change.Auto-generated by CI failure analyzer