t6 sentiment: finbert serving behind a protocol, POST /v1/sentiment off the event loop - #1
Merged
Merged
Conversation
…actory, POST /v1/sentiment via to_thread
…ted concurrency test, composition root, literal labels + prob range guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
domain/sentiment.py—SentimentModelProtocol (the serving seam), pureto_scoremapping (argmax label, quantized Decimal probs, rejects wrong label sets / out-of-range values),FinBertModeladapter (ProsusAI/finbert, heavy imports deferred to construction, loaded once).serving/— FastAPI app factory with DI viaapp.state,POST /v1/sentiment(label + probs + model_version),GET /health/live. Inference runs on a dedicated single-worker executor: keeps the event loop free, serializes forward passes (no CPU oversubscription), and sidesteps HF fast-tokenizer thread-safety.main.py— composition root: build FinBERT once, serve with uvicorn (python -m hodlin_recommend.main).tests
HODLIN_TEST_FINBERT=1): verified locally — positive/negative texts score correctly through the endpoint, model_versionfinbert:ProsusAI/finbert.