Align td and th with css instead of align property#147
Merged
Conversation
When you align tables with css, <td align="..."> gets overridden. Using inline styles keeps alignment no matter what CSS contains.
|
+1 |
Owner
|
Hey, nice change, but this needs to go in Sundown upstream so I can backport it. Would you mind opening the PR there? 💜 |
Contributor
Author
|
I have figured it out already, but I had no time to do that. I will do it though. |
Contributor
Author
|
Sundown has been discontinued, my other issue is open for a while, and I can't reopen this issue. 😞 |
ghost
assigned
Collaborator
|
@mattr- : Any news on this? 😄 If you want me to merge it, I'm ok. Let me know ; I could also add a test for this. |
Collaborator
|
Please go ahead and merge it. Thanks! ❤️ |
robin850
added a commit
that referenced
this pull request
Jul 24, 2013
Align td and th with css instead of align property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you align tables with css, gets overridden, and content creator has no control on alignment.
However, inline styles takes precedence over any CSS the page has.