This repository was archived by the owner on Oct 28, 2022. It is now read-only.
LDR Password / SSH Options#472
Open
kalenarndt wants to merge 1 commit intovmware-archive:masterfrom
kalenarndt:master
Open
LDR Password / SSH Options#472kalenarndt wants to merge 1 commit intovmware-archive:masterfrom kalenarndt:master
kalenarndt wants to merge 1 commit intovmware-archive:masterfrom
kalenarndt:master
Conversation
Copied the settings and parameters from New-NSXEdge to the New-NSXLogicalRouter function. The XML structure is the same and if a password isn't specified during deployment, console login will fail. Password is set to a mandatory value so this might break deployments that don't specify one.
alagoutte
reviewed
Feb 8, 2018
| [System.XML.XMLElement]$xmlCliSettings = $XMLDoc.CreateElement("cliSettings") | ||
| $xmlRoot.appendChild($xmlCliSettings) | out-null | ||
|
|
||
| if ( $PsBoundParameters.ContainsKey('Password') ) { |
Contributor
There was a problem hiding this comment.
No need to check because it is always a value...
Contributor
|
Do you have run testsuite ? (specialty tests/integration/03.Logical.Router...) Why make password mandatory ? |
Contributor
Author
|
I set the password to required because you can't login to the LDR via SSH or through the console since a password was never set. In order to fix this you have to modify the edge and set a password through the NSX UI. I figured that since this is the one edge object that doesn't have a password parameter and it is required for the other objects, that it should line up to support that. As far as the testsuite I haven't but I did just deploy the DLR via a script that set the password via my repo and tested login functionality. |
dcoghlan
added
the
Test Required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied the settings and parameters from New-NSXEdge to the New-NSXLogicalRouter function.
The XML structure is the same and if a password isn't specified during deployment, console login will fail.
Password is set to a mandatory value so this might break deployments that don't specify one.
Documentation is wrong and says the password is required during the deployment but the DLR deploys with some magic default password if you don't set one.