feat: make backoffLimit configurable for Helm jobs#723
Open
fabioaraujopt wants to merge 5 commits intovmware-tanzu:mainfrom
Open
feat: make backoffLimit configurable for Helm jobs#723fabioaraujopt wants to merge 5 commits intovmware-tanzu:mainfrom
fabioaraujopt wants to merge 5 commits intovmware-tanzu:mainfrom
Conversation
Collaborator
|
@fabioaraujopt please help bump chart version, thank you. |
Author
fixed |
Make backoffLimit configurable for the Velero upgrade, cleanup, and namespace-label jobs while keeping a default of 3. Add nil-safe template fallbacks so upgrades with older or partial values do not fail with nil pointer errors. Signed-off-by: Fabio Araujo <fabioaraujoorg@gmail.com>
fabioaraujopt
force-pushed
the
feature/configurable-backoff-limit
branch
from
2813aad to
fca386e
Compare
Author
|
ready to review |
jenting
reviewed
Feb 23, 2026
jenting
reviewed
Feb 25, 2026
| helm.sh/chart: {{ include "velero.chart" . }} | ||
| spec: | ||
| backoffLimit: 3 | ||
| backoffLimit: {{ default 3 $cleanUpCRDsJob.backoffLimit }} |
Collaborator
There was a problem hiding this comment.
Please consider remove the default setting at here as well.
| {{- toYaml .Values.kubectl.extraVolumes | nindent 6 }} | ||
| {{- end }} | ||
| backoffLimit: 3 | ||
| backoffLimit: {{ default 3 $labelNamespaceJob.backoffLimit }} |
Collaborator
There was a problem hiding this comment.
Please consider remove the default setting at here as well.
| description: A Helm chart for velero | ||
| name: velero | ||
| version: 11.3.2 | ||
| version: 11.4.0 |
Collaborator
There was a problem hiding this comment.
Please help rebase to the latest branch and bump version.
Collaborator
|
@fabioaraujopt please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the
backoffLimitconfigurable for Velero's Helm job resources, allowing users to adjust retry limits based on their environment needs.Motivation
The current hardcoded
backoffLimitof 3 may be insufficient in environments with:This is particularly problematic for the
velero-upgrade-crdsjob which runs as a Helm pre-install/pre-upgrade hook and can cause installation failures when it exceeds the backoff limit.Changes
upgradeCRDsJob.backoffLimitconfiguration (default: 3)cleanUpCRDsJob.backoffLimitconfiguration (default: 3)labelNamespaceJob.backoffLimitconfiguration (default: 3)Backward Compatibility
✅ All defaults are set to 3, maintaining current behavior.
Usage
Users can now override the backoff limit in their values:
Testing
Related Issues
Addresses scenarios where users encounter
BackoffLimitExceedederrors during Velero installation.