Fix install from local RPMs with --installroot and --disablerepo=*#562
Open
sshedi wants to merge 1 commit intovmware:devfrom
Open
Fix install from local RPMs with --installroot and --disablerepo=*#562sshedi wants to merge 1 commit intovmware:devfrom
sshedi wants to merge 1 commit intovmware:devfrom
Conversation
sshedi
force-pushed
the
installrepo
branch
3 times, most recently
from
91556e4 to
9afa08c
Compare
Internalize the cmdline repo before building file provides so file deps (e.g. /usr/bin/cp for bash) are satisfied from the RPMs being installed. Add pytest that runs this scenario when package server is reachable Fixes: e890607 Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
Contributor
|
The fix and the test do not seem related - please separate into two commits, and update the title and description, or create a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internalise the cmdline repo before building file provides so that file dependencies (e.g. /usr/bin/cp for bash) are satisfied from the RPMs being installed. Without this, file provides were built before the cmdline repo was internalized, so the solver did not see them and resolution failed with "nothing provides ...".
Add a pytest that reproduces this scenario (download bash then install from local RPMs into installroot with --disablerepo=*), skipped when the package server is unreachable.
Fixes: e890607