Repository navigation
Add Settings and Add Account buttons to the main window - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SettingsLink.Add Account…button to the sidebar. It opens the existingAccountFormin a sheet, so validation and Keychain handling stay in one place.Closes #1
Closes #2
How it was tested
swift test(57 tests)Tests/Integration/run.py, if SIP behaviour changed: not run, no SIP code changedTwo new XCUITests pass in the real app: the Settings button brings the window forward without opening a second one, and the Add Account sheet opens and cancels with no accounts.
A temporary XCUITest also added extension 1006 from the sheet against the Asterisk rig. The sheet closed and the sidebar and Asterisk both showed it registered, without a relaunch. That test isn't included, because registering 1006 would interfere with
run_app.py.run_app.pywas not run, so the incoming call UI test hasn't run against this change.