Skip to content

Add Settings and Add Account buttons to the main window - #20

Merged
vo1dee merged 2 commits into
mainfrom
main-window-buttons
Nov 2, 2026
Merged

vo1dee merged 2 commits into
mainfrom
main-window-buttons

Conversation

@vo1dee

@vo1dee vo1dee commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • Added a Settings button to the main window toolbar, using SettingsLink.
  • Added an Add Account… button to the sidebar. It opens the existing AccountForm in a sheet, so validation and Keychain handling stay in one place.
  • The Accounts section in the sidebar now always shows, so the button is available with no accounts, for example after Configure Later in onboarding.
  • Bumped the version to 1.1.0 (build 2) and added a changelog entry.

Closes #1
Closes #2

How it was tested

  • swift test (57 tests)
  • Tests/Integration/run.py, if SIP behaviour changed: not run, no SIP code changed
  • Docs updated, including KNOWN_LIMITATIONS.md and CHANGELOG.md where relevant: CHANGELOG.md only, no limitations changed

Two new XCUITests pass in the real app: the Settings button brings the window forward without opening a second one, and the Add Account sheet opens and cancels with no accounts.

A temporary XCUITest also added extension 1006 from the sheet against the Asterisk rig. The sheet closed and the sidebar and Asterisk both showed it registered, without a relaunch. That test isn't included, because registering 1006 would interfere with run_app.py.

run_app.py was not run, so the incoming call UI test hasn't run against this change.

@vo1dee
vo1dee merged commit 7c0f846 into main Nov 2, 2026
1 check passed
@vo1dee
vo1dee deleted the main-window-buttons branch November 2, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an "Add Account" button to the main window Add a Settings button to the main window

1 participant