[v0.0.7] Fix proxy support in AutomationWorkflow file download - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in v0.0.6 where proxy settings were not properly applied to file downloads in AutomationWorkflow. The
download_output_file()method was directly callingrequests.get()instead of using the configured session, bypassing proxy settings.Changes
Bug Fix
src/pyaps/automation/workflow.py)requests.get(url)toself.dm.http_oss.session.get(url)Documentation
pyproject.toml)Why This Matters
In v0.0.6, we added proxy support to all HTTP clients, but the workflow's file download method was still using a direct
requestscall. This meant that in enterprise environments requiring proxies:Now all HTTP traffic consistently uses the configured session with proxy settings.