Skip to content

[v0.0.7] Fix proxy support in AutomationWorkflow file download - #11

Merged
LeonardNoh merged 1 commit into
voidbox-ai:mainfrom
LeonardNoh:main
Nov 14, 2025
Merged

[v0.0.7] Fix proxy support in AutomationWorkflow file download#11
LeonardNoh merged 1 commit into
voidbox-ai:mainfrom
LeonardNoh:main

Conversation

@LeonardNoh

Copy link
Copy Markdown
Contributor

Summary

Fixes a bug in v0.0.6 where proxy settings were not properly applied to file downloads in AutomationWorkflow. The download_output_file() method was directly calling requests.get() instead of using the configured session, bypassing proxy settings.

Changes

Bug Fix

  • AutomationWorkflow.download_output_file() (src/pyaps/automation/workflow.py)
    • Changed from requests.get(url) to self.dm.http_oss.session.get(url)
    • Now properly uses DataManagementClient's session which includes proxy configuration
    • Ensures all HTTP requests respect proxy settings

Documentation

  • Version bump to 0.0.7 (pyproject.toml)
  • README updated with v0.0.7 entry in version history

Why This Matters

In v0.0.6, we added proxy support to all HTTP clients, but the workflow's file download method was still using a direct requests call. This meant that in enterprise environments requiring proxies:

  • File uploads worked (using session) ✓
  • API calls worked (using session) ✓
  • File downloads failed (not using session) ✗

Now all HTTP traffic consistently uses the configured session with proxy settings.

@LeonardNoh
LeonardNoh merged commit 4d8e84a into voidbox-ai:main Nov 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant