Repository navigation
feat(dev): published LIVE builds for Diff; apply reads Data.p4k only - #42
Merged
Merged
Conversation
Rescope published dumps (voidput/sc-gamedata-dumps) to Developer mode's
Datasets/Diff: download past LIVE builds and compare old vs new. Apply
always reads Data.p4k locally.
- core: DumpTransport::releases, live_releases, tag-based fetch_verified
over every data/*.json (blob SHA-1 + _build checks), DumpCache
entry/list/remove; drop PublishedDump, DumpFirst, to_game_data,
recover_loc_keys, match_build
- net: GitHub release list (published_at, drafts skipped)
- app contract: dev_dump_releases, dev_download_dump({target, tag}) as a
dev job, dump:<tag> sources (SHA-256 re-checked on read, usable with the
switch off, removable); mocks serve two synthetic LIVE builds
- settings: network.published_dumps is a real switch, "Download published
LIVE builds for Diff"
- setup: drop the "Game data source" step and SetupRequest.data_source
- cli: drop the published-dumps feature and --use-published-data; no HTTP
- docs: privacy, user guide, addendum §1/§7.5/§7.6 rescope notes, todo
- core: refuse builds over 512 MiB before downloading; write each
verified file to a per-download temp dir as it arrives; prune stale
*.tmp-* dirs on listing; ignore meta.json entries with unsafe or
case-colliding names; DumpError (not published / refused / network /
stopped); progress callback can stop the download
- app: re-check the switch before every file (off = network-off, no
further request); dev_dump_releases returns { releases, error } so an
offline or rate-limited GitHub still lists downloaded builds; network
failures say "Could not reach GitHub"; checksum text without the
"archive check failed" prefix; missing or unreadable cached files put
the source in Error
- mocks match the real backend: invalid for a bad tag, same not-found
text, same progress steps incl. "Checking"
- net: follow up to 3 pages of 100 releases
- tests: failing transport, switch off mid-download, progress sequence,
build cap, case collisions, stale temp dirs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Published game data is now used only for comparing old vs new LIVE builds in Developer mode. Apply always reads Data.p4k on this computer.
Changes
voidput/sc-gamedata-dumps, with download and remove buttons. A downloaded build becomes adump:<tag>source and can be picked as A or B in Diff. Downloaded builds keep working with the switch off and when GitHub is unreachable.dev_dump_releases -> DumpReleases { releases, error };dev_download_dump(DevDumpRequest { target, tag })runs as a dev job with progress;dev_remove_sourcedeletes a downloaded build._buildstamp. SHA-256 is re-checked on load. A build may be at most 512 MiB, files are streamed to disk, and the switch is re-checked before every file.DumpFirst/PublishedDump(dumps feeding apply).published-dumpsfeature and--use-published-data. The CLI has no HTTP client at all now.SetupRequest.data_source. An old frontend that still sends it keeps working, and saved wizard drafts resume at the same step.Verification
native_flowtests fail only because the game was running locally.cargo test -p starorg-codex-app --test real_dev real_network_smoke -- --ignored): downloaded 4.10.197.2878 (17.6 MB) and 4.10.200.58746 (24.1 MB), then diffed them: 87 tables, 35 differ, +13,590 / ~1,908 records.Refs #15