chore(task): add test for empty new line#203
Merged
Merged
Conversation
fengmk2
changed the title
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
changed the title
fengmk2
marked this pull request as ready for review
September 25, 2025 06:58
fengmk2
changed the base branch from
09-25-feat_task_support_fast_failure_exit
to
graphite-base/203
September 25, 2025 07:05
fengmk2
force-pushed
the
09-25-chore_task_remove_unuse_empty_line
branch
from
September 25, 2025 07:05
844aafe to
e81cb21
Compare
fengmk2
force-pushed
the
graphite-base/203
branch
from
September 25, 2025 07:05
f3c721a to
7fc6f5f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary blank lines from task execution output to improve readability. The changes address extra newlines that were appearing after task executions and in various output scenarios.
- Remove redundant
println!()statement in task execution code - Update snapshot tests to reflect cleaner output formatting without extra blank lines
- Ensure consistent output formatting across different task execution scenarios
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/vite_task/src/schedule.rs | Remove extra println statement that was adding unnecessary newlines |
| packages/cli/snap-tests/*/snap.txt | Update test snapshots to reflect removal of extra blank lines in task output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fengmk2
force-pushed
the
09-25-chore_task_remove_unuse_empty_line
branch
from
September 25, 2025 07:39
cde5845 to
0bf3cde
Compare
fengmk2
changed the title
wan9chi
approved these changes
Sep 25, 2025
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.