-
Notifications
You must be signed in to change notification settings - Fork 234
fix: preserve signal exit code on Unix #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liangmiQwQ
wants to merge
12
commits into
voidzero-dev:main
Choose a base branch
from
liangmiQwQ:liang/codex/preserve-signal-exit-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9166cde
fix(command): preserve signal exit codes
liangmiQwQ 924c1c3
fix(command): preserve signals across process runners
liangmiQwQ f931ecc
refactor(snapshots): reuse shared exit status mapping
liangmiQwQ ead506b
clean up
liangmiQwQ c1ab21d
clean up
liangmiQwQ 52803ca
Merge remote-tracking branch 'upstream/main' into liang/codex/preserv…
liangmiQwQ f822831
test(cli): keep interrupt snapshot stable
liangmiQwQ 75ac2cf
Merge branch 'main' into liang/codex/preserve-signal-exit-code
liangmiQwQ 4e677a8
ci: retrigger checks
liangmiQwQ da0e7dc
fix(snapshots): stabilize JSON edit key order
liangmiQwQ dd3c5c0
Merge branch 'main' into liang/codex/preserve-signal-exit-code
liangmiQwQ e10de60
Merge branch 'main' into liang/codex/preserve-signal-exit-code
liangmiQwQ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| use std::process::ExitStatus; | ||
|
|
||
| /// Convert a process status to the shell-compatible exit code used by CLI callers. | ||
| pub fn exit_code_from_status(status: ExitStatus) -> i32 { | ||
| #[cfg(unix)] | ||
| { | ||
| use std::os::unix::process::ExitStatusExt; | ||
| if let Some(signal) = status.signal() { | ||
| return 128 + signal; | ||
| } | ||
| } | ||
| status.code().unwrap_or(1) | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| #[cfg(unix)] | ||
| mod tests { | ||
| use super::exit_code_from_status; | ||
|
|
||
| /// Regression test for https://github.com/voidzero-dev/vite-plus/issues/2041. | ||
| #[test] | ||
| fn preserves_signal_exit_code() { | ||
| let status = | ||
| std::process::Command::new("/bin/sh").arg("-c").arg("kill -ILL $$").status().unwrap(); | ||
| assert_eq!(exit_code_from_status(status), 132); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because this PR adds
vite_sharedcrate as a dependency. Andvite_sharedenablesserde_json/preserve_orderfeature, while Cargo is merging this change, json object will no longer be sorted, causes unrelated snapshots to differ.