Skip to content

fix(migration): add Svelte rune globals to Oxlint config#2174

Closed
naokihaba wants to merge 0 commit into
voidzero-dev:mainfrom
naokihaba:main
Closed

fix(migration): add Svelte rune globals to Oxlint config#2174
naokihaba wants to merge 0 commit into
voidzero-dev:mainfrom
naokihaba:main

Conversation

@naokihaba

Copy link
Copy Markdown
Collaborator

resolves: #1967

@naokihaba naokihaba self-assigned this Jul 14, 2026
@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit b9acb2f
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a58e1a0c1e8c70008efba5e

@naokihaba

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b813f0592

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/vite-config.ts Outdated
@naokihaba

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: c437d33f92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@naokihaba

Copy link
Copy Markdown
Collaborator Author

I accidentally closed this PR by force-pushing to my fork's main branch while syncing it with upstream. This removed the commits I had made here, so there's no longer a diff between the branches. I just wanted to clarify that it wasn't closed because the changes were rejected. I'll get a new PR open from a dedicated feature branch in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vp create svelte generates config where vp check reports $props as no-undef

1 participant