fix(migrate): support pnpm 10 peer overrides#2183
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c474fed3c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!pnpmNeedsPeerOverrideCompatibility(pnpmVersion)) { | ||
| return false; |
There was a problem hiding this comment.
Remove obsolete pnpm peer-compat selectors
After this helper has written pkg>vite selectors for pnpm 10.0/10.1, rerunning the bootstrap on pnpm 10.2.0–10.6.1 exits here and never removes them; the workspace-settings path only cleans selector overrides at 10.6.2+. Those selectors are more specific than the global vite override (pnpm documents qar@1>zoo as overriding that package's zoo dependency), so the stale public range continues to bypass the Vite+ core alias for that workspace even though the pnpm peer-validation bug is fixed.
Useful? React with 👍 / 👎.
Summary
This was found as a release blocker while smoke-testing the v0.2.5 preview against Vize, which pins pnpm 10.0.0.
Validation
vp checkpnpm -F vite-plus exec vitest run src/migration(366 passed)pnpm -F vite-plus exec vitest run src/migration/__tests__/migrator.spec.ts(320 passed)just snapshot-test migration(143 passed; six registry-contention timeouts all passed when rerun in isolation)vp why -r vite-plus vite vitestreported exactly one version of Vite+, Vite, and Vitest