Skip to content

test: add test for vitest browser mode#235

Merged
wan9chi merged 2 commits into
mainfrom
10-19-test_vitest_browser_mode
Oct 20, 2025
Merged

test: add test for vitest browser mode#235
wan9chi merged 2 commits into
mainfrom
10-19-test_vitest_browser_mode

Conversation

@wan9chi

@wan9chi wan9chi commented Oct 19, 2025

Copy link
Copy Markdown
Member

The added vitest browser mode test will be fixed and enabled in #234

wan9chi commented Oct 19, 2025

Copy link
Copy Markdown
Member Author

@wan9chi wan9chi changed the title test vitest browser mode test: add test for vitest browser mode Oct 19, 2025
@wan9chi
wan9chi marked this pull request as ready for review October 19, 2025 15:59
Copilot AI review requested due to automatic review settings October 19, 2025 15:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds end-to-end snapshot tests for Vitest’s browser mode and stabilizes snapshots across platforms, especially macOS symlink paths and timing units.

  • Add Vitest browser mode snap test and related fixtures
  • Normalize duration outputs (including µs) and resolve tmpdir symlink to stabilize in snapshots
  • Update CI to run E2E on Ubuntu/mac and install Playwright Chromium

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pnpm-workspace.yaml Adds @vitest/browser and playwright to catalog to support browser-mode tests
packages/tools/src/utils.ts Extends unstable output normalization to include µs and adjusts duration replacement placement
packages/tools/src/snap-test.ts Resolves tmpdir symlink, symlinks node_modules into temp dirs, and adds per-test platform skipping
packages/cli/snap-tests/yarn-install-with-options/steps.json Adds ignoredPlatforms to skip on Linux
packages/cli/snap-tests/yarn-install-with-options/snap.txt Updates expected default cwd output after symlink resolution
packages/cli/snap-tests/vitest-browser-mode/vitest.config.ts Adds Vitest browser mode configuration (Playwright/Chromium)
packages/cli/snap-tests/vitest-browser-mode/steps.json Defines steps for browser-mode snap test, skipping on Linux
packages/cli/snap-tests/vitest-browser-mode/src/* Adds simple test and sources used by the browser-mode test
packages/cli/snap-tests/vitest-browser-mode/snap.txt Snapshot for browser-mode test runs and cache behavior
packages/cli/snap-tests/vitest-browser-mode/package.json Empty placeholder for test fixture
packages/cli/snap-tests/fingerprint-ignore-test/steps.json Adds ignoredPlatforms to skip on Linux
packages/cli/package.json Declares @vitest/browser and playwright as devDependencies for CLI package
.github/workflows/ci.yml Adds Ubuntu to matrix and installs Playwright Chromium before E2E tests
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/tools/src/snap-test.ts Outdated
Comment thread packages/tools/src/snap-test.ts Outdated
Comment thread .github/workflows/ci.yml
Comment thread packages/cli/snap-tests/vitest-browser-mode/vitest.config.ts
Copilot AI review requested due to automatic review settings October 20, 2025 01:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/tools/src/utils.ts
Comment thread packages/cli/snap-tests/vitest-browser-mode/vitest.config.ts
Comment thread .github/workflows/ci.yml
@wan9chi
wan9chi force-pushed the 10-19-test_vitest_browser_mode branch from 8b46431 to 4049e8b Compare October 20, 2025 02:16
Copilot AI review requested due to automatic review settings October 20, 2025 02:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/cli/snap-tests/vitest-browser-mode/vitest.config.ts

wan9chi commented Oct 20, 2025

Copy link
Copy Markdown
Member Author

Merge activity

  • Oct 20, 2:43 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 20, 2:43 AM UTC: @branchseer merged this pull request with Graphite.

@wan9chi
wan9chi merged commit 138807a into main Oct 20, 2025
10 checks passed
@wan9chi
wan9chi deleted the 10-19-test_vitest_browser_mode branch October 20, 2025 02:43
wan9chi added a commit that referenced this pull request Oct 23, 2025
Chromium processes can now be successfully tracked after #234, and we have it monitored since #235.
wan9chi pushed a commit that referenced this pull request Mar 13, 2026
Includes:
- ux: hint Escape key when no tasks match in interactive selector (#235)
- docs: overhaul README.md, CLAUDE.md and add CONTRIBUTING.md (#234)

https://claude.ai/code/session_0139LsSbe67hcD8NKKaK6Y8U
@wan9chi wan9chi mentioned this pull request Mar 13, 2026
2 tasks
wan9chi added a commit that referenced this pull request Mar 13, 2026
## Summary
- Bump vite-task from `28f371a1` to `398a147f`
- Includes: hint Escape key when no tasks match in interactive selector
(#235), overhaul README/CLAUDE.md and add CONTRIBUTING.md (#234)

## Test plan
- [x] `cargo check` passes
- [ ] CI passes

https://claude.ai/code/session_0139LsSbe67hcD8NKKaK6Y8U

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants