Skip to content

test: add test for type-aware linting#253

Merged
wan9chi merged 2 commits into
mainfrom
10-24-test_add_test_for_type-aware_linting
Oct 24, 2025
Merged

test: add test for type-aware linting#253
wan9chi merged 2 commits into
mainfrom
10-24-test_add_test_for_type-aware_linting

Conversation

@wan9chi

@wan9chi wan9chi commented Oct 24, 2025

Copy link
Copy Markdown
Member

Disabled on Linux for now. Will enable with a fix in a separate PR.

wan9chi commented Oct 24, 2025

Copy link
Copy Markdown
Member Author

@wan9chi
wan9chi marked this pull request as ready for review October 24, 2025 08:32
Copilot AI review requested due to automatic review settings October 24, 2025 08:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a snapshot test suite to verify type-aware linting functionality in oxlint. The test demonstrates that type-aware linting correctly detects changes in TypeScript type definition files and invalidates cache accordingly, while non-type-aware linting does not.

Key changes:

  • New snapshot test that validates type-aware vs non-type-aware linting behavior
  • Test is temporarily disabled on Linux pending a fix in a future PR

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/cli/snap-tests/oxlint-typeaware/types.ts Adds a simple type definition file used to test type-aware linting detection
packages/cli/snap-tests/oxlint-typeaware/steps.json Defines test commands that verify cache behavior differs between type-aware and non-type-aware modes
packages/cli/snap-tests/oxlint-typeaware/src/index.ts Creates a source file that imports the type, establishing a dependency relationship
packages/cli/snap-tests/oxlint-typeaware/snap.txt Expected output showing cache hit for non-type-aware and cache miss for type-aware linting
packages/cli/snap-tests/oxlint-typeaware/package.json Empty package.json required for the test suite structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wan9chi
wan9chi merged commit 61f7745 into main Oct 24, 2025
10 checks passed

wan9chi commented Oct 24, 2025

Copy link
Copy Markdown
Member Author

Merge activity

  • Oct 24, 8:37 AM UTC: @branchseer merged this pull request with Graphite.

@wan9chi
wan9chi deleted the 10-24-test_add_test_for_type-aware_linting branch October 24, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants