fix(plan): add shell arguments for shell fallback execution#100
Merged
wan9chi merged 5 commits intoJan 14, 2026
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 13, 2026
wan9chi
force-pushed
the
01-13-fix_plan_add_shell_arguments_for_shell_fallback_execution
branch
3 times, most recently
from
January 13, 2026 12:40
26a882b to
99485c2
Compare
wan9chi
changed the base branch from
01-13-test_split_plan_tests_and_execution_test
to
graphite-base/100
January 13, 2026 13:35
wan9chi
force-pushed
the
01-13-fix_plan_add_shell_arguments_for_shell_fallback_execution
branch
from
January 13, 2026 13:37
99485c2 to
9b192dd
Compare
wan9chi
force-pushed
the
graphite-base/100
branch
from
January 13, 2026 13:37
006de3f to
0492491
Compare
wan9chi
force-pushed
the
01-13-fix_plan_add_shell_arguments_for_shell_fallback_execution
branch
from
January 13, 2026 13:38
9b192dd to
2077ae0
Compare
wan9chi
force-pushed
the
01-13-fix_plan_add_shell_arguments_for_shell_fallback_execution
branch
from
January 13, 2026 13:41
2077ae0 to
26fc1b7
Compare
wan9chi
marked this pull request as ready for review
January 13, 2026 13:44
Windows path casing can vary (e.g., System32 vs system32), which caused the snapshot redaction to fail on Windows CI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move extension stripping to happen before shell path/name comparison so that "cmd.exe" becomes "cmd" before we check if it matches the shell name. Also update os_shell_path to not include .exe since the extension is already stripped. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
fengmk2
approved these changes
Jan 14, 2026
Member
Author
wan9chi
deleted the
01-13-fix_plan_add_shell_arguments_for_shell_fallback_execution
branch
January 14, 2026 03:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.