Skip to content

refactor: make TrackedChild easier to use#20

Merged
wan9chi merged 5 commits into
mainfrom
11-07-refactor_make_trackedchild_easier_to_use
Nov 7, 2025
Merged

refactor: make TrackedChild easier to use#20
wan9chi merged 5 commits into
mainfrom
11-07-refactor_make_trackedchild_easier_to_use

Conversation

@wan9chi

@wan9chi wan9chi commented Nov 7, 2025

Copy link
Copy Markdown
Member

refactor: make TrackedChild easier to use

This PR refactors the TrackedChild struct to make it easier to use by:

  • Adding a ChildTermination struct that contains both the exit status and path accesses
  • Providing a wait_handle future that resolves to ChildTermination when the process exits
  • Exposing stdin, stdout, and stderr handles directly on TrackedChild
  • Automatically locking the IPC channel when the child process exits
  • Updating all usages of TrackedChild throughout the codebase

wan9chi commented Nov 7, 2025

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wan9chi
wan9chi marked this pull request as ready for review November 7, 2025 02:20
@wan9chi
wan9chi requested a review from fengmk2 November 7, 2025 02:49
@wan9chi
wan9chi merged commit ba48c0e into main Nov 7, 2025
6 checks passed
@Brooooooklyn
Brooooooklyn deleted the 11-07-refactor_make_trackedchild_easier_to_use branch December 11, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants