Skip to content

feat: eargerly scan topologically dependencies#49

Merged
wan9chi merged 5 commits into
mainfrom
12-05-feat_eargerly_scan_topologically_dependencies
Dec 5, 2025
Merged

feat: eargerly scan topologically dependencies#49
wan9chi merged 5 commits into
mainfrom
12-05-feat_eargerly_scan_topologically_dependencies

Conversation

@wan9chi

@wan9chi wan9chi commented Dec 5, 2025

Copy link
Copy Markdown
Member

feat: Add topological dependency scanning to task graph

This PR adds automatic topological dependency scanning to the task graph, allowing tasks to depend on tasks with the same name in dependent packages. Key changes include:

  • Eagerly scan for topological dependencies between tasks based on package dependencies
  • Add support for dependencies that are both explicit and topological with a new Both type
  • Create a TaskIx newtype for better type safety in task graph indices
  • Wrap TaskDependencyTypeInner in TaskDependencyType to provide safer API for checking dependency types
  • Update task graph to use package indices instead of package paths for better performance
  • Add tests for the new topological dependency scanning functionality

wan9chi commented Dec 5, 2025

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wan9chi
wan9chi marked this pull request as ready for review December 5, 2025 08:37

@fengmk2 fengmk2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wan9chi
wan9chi merged commit cf8daeb into main Dec 5, 2025
6 checks passed
@Brooooooklyn
Brooooooklyn deleted the 12-05-feat_eargerly_scan_topologically_dependencies branch December 11, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants