fix(test): wait for rendered milestone fences#527
Merged
Conversation
Co-authored-by: GPT-5.6 <codex@openai.com>
Co-authored-by: GPT-5.6 <codex@openai.com>
Member
Author
|
Namespace verification evidence:
|
Co-authored-by: GPT-5.6 <codex@openai.com>
Co-authored-by: GPT-5.6 <codex@openai.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-authored-by: GPT-5.6 <codex@openai.com>
wan9chi
added a commit
that referenced
this pull request
Jul 9, 2026
## What changed Revert #527, removing the rendered zero-width milestone fence implementation and its dependency changes. ## Motivation The anonymous FIFO fence protocol does not handle ConPTY coalescing or multiple milestone-producing processes reliably. Reverting it restores the prior marker behavior while a cross-platform window-title-based protocol with process-unique nonces is designed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
On Windows Server 2022 build 20348, ConPTY can emit an OSC 8 milestone before printable text that the child wrote and flushed first.
expect_milestonereturned as soon as it decoded the control marker, so milestone screen assertions could observe an empty terminal.What changed
anyhow,crossbeam-epoch, andmemmap2to releases that fix the advisories reported by Security Analysis.