Skip to content

fix: add missing workloadName for CodeInterpreter sandboxes #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarshitPal25 wants to merge 1 commit into from
+1 −0
Closed

fix: add missing workloadName for CodeInterpreter sandboxes #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/workloadmanager/workload_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ func buildSandboxByCodeInterpreter(namespace string, codeInterpreterName string,
buildParams := &buildSandboxParams{
sandboxName: sandboxName,
namespace: namespace,
workloadName: codeInterpreterName,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR aims to add the missing workloadName to CodeInterpreter sandboxes, but the fix appears to be incomplete based on the PR description's goal of covering "all CodeInterpreter Sandbox objects".

The "warm pool" path (lines 370-399) also creates a Sandbox object (line 384) and a SandboxClaim (line 371) that are currently missing the WorkloadNameLabelKey label. To ensure all CodeInterpreter workloads are correctly labeled for queries and debugging, these objects should also be updated to include the workloadName label.

sessionID: sessionID,
podSpec: podSpec,
podLabels: codeInterpreterObj.Spec.Template.Labels,
Comment on lines 425 to 431
Expand Down
Loading