Skip to content

fix: add missing workloadName for CodeInterpreter sandboxes #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarshitPal25 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

fix: add missing workloadName for CodeInterpreter sandboxes #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/workloadmanager/workload_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ func buildSandboxByCodeInterpreter(namespace string, codeInterpreterName string,
buildParams := &buildSandboxParams{
sandboxName: sandboxName,
namespace: namespace,
workloadName: codeInterpreterName,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly addresses the missing workloadName for the direct sandbox creation path, the fix appears incomplete based on the PR description. The WorkloadNameLabelKey label is still missing in the warm pool path (when WarmPoolSize > 0). Specifically, the simpleSandbox object created at line 384 and the SandboxClaim created at line 371 should also include the WorkloadNameLabelKey label to ensure consistency across all CodeInterpreter workloads.

sessionID: sessionID,
Comment on lines 425 to 429
podSpec: podSpec,
podLabels: codeInterpreterObj.Spec.Template.Labels,
Expand Down
Loading