feat: refactor tables to TanStack Table and consolidate components#232
feat: refactor tables to TanStack Table and consolidate components#232prakharsingh-74 wants to merge 1 commit intovolcano-sh:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: prakharsingh-74 <prakharsingh7014@gmail.com>
b769edc to
3ab3181
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces @tanstack/react-table to manage data and rendering for the JobTable, PodGroupsTable, PodsTable, and QueueTable components. It renames JobFilters to TableFilterMenu, updates its event handlers, and integrates edit and delete dialogs directly into the table components, allowing for the removal of several redundant sub-components. I have no feedback to provide.
fixes: #85
Description:
This PR transitions the dashboard's table implementations from a purely MUI-based approach to using TanStack Table. This refactor addresses the previous fragmentation by consolidating table logic and UI into a more maintainable, "headless" architecture.
Core Improvements:
JobTable,PodsTable,QueueTable, andPodGroupsTableto utilize@tanstack/react-table. This leverages industry-standard data management while keeping our custom MUI styling.HeaderandRowfiles. Each table's structure is now defined via a cleancolumnsconfiguration within its primary component.TableFilterMenucomponent. This ensures that filtering interactions (Namespace, Status, etc.) are perfectly consistent across the entire application.Cleanup: