feat: implemented e2e test for router config-update by katara-Jayprakash · Pull Request #921 · volcano-sh/kthena

katara-Jayprakash · 2026-04-24T15:49:08Z

Description:
Adds an E2E test that verifies updating the router's ConfigMap and restarting the pods picks up the new configuration.

What the test does:

Sends a request with the default config to confirm routing works
Updates the router ConfigMap to use only least-request as the score plugin (removes gpu-usage, least-latency, prefix-cache) and bumps maxWaitingRequests to 100
Deletes router pods and waits for fresh ones to come up
Checks scheduler plugin metrics to verify only the configured plugins are active
Sends another request to confirm routing still works after restart
Cleans up by restoring the original ConfigMap and restarting pods

Fix: #853

gemini-code-assist

Code Review

This pull request introduces end-to-end tests to verify that updating the router's configuration via a ConfigMap and restarting the deployment correctly applies the new settings. The tests cover both standard and Gateway API scenarios, validating routing functionality and scheduler plugin metrics after the update. Feedback includes simplifying label selector construction using standard library functions, addressing a potential resource leak with unclosed port-forwards in cleanup blocks, and ensuring ConfigMap updates use fresh objects to avoid concurrency conflicts.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds an end-to-end test that validates router ConfigMap updates take effect after restarting the router, shared across the “router” and “gateway-api” e2e suites.

Changes:

Introduces TestRouterConfigUpdateShared to update the router ConfigMap, restart router pods, and verify behavior + metrics.
Adds suite-specific wrapper tests in both router and gateway-api packages to run the shared test.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
test/e2e/router/shared.go	Adds shared e2e test logic for updating router config, restarting pods, and validating metrics.
test/e2e/router/gateway-api/e2e_test.go	Adds a Gateway API wrapper test calling the shared test helper.
test/e2e/router/e2e_test.go	Adds a non-Gateway API wrapper test calling the shared test helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

katara-Jayprakash · 2026-04-25T01:37:43Z

/cc @LiZhenCheng9527 @YaoZengzeng @hzxuzhonghu @FAUST-BENCHOU e2e are passing! feel free to review this!

hzxuzhonghu · 2026-04-27T08:41:31Z

/assign @YaoZengzeng

YaoZengzeng · 2026-05-08T02:32:30Z

This test should also be added to https://github.com/volcano-sh/kthena/blob/main/test/e2e/router/gateway-inference-extension/e2e_test.go

katara-Jayprakash · 2026-05-09T03:37:18Z

+
+	// Register cleanup to restore original ConfigMap, restart router, and
+	// re-establish port-forward for subsequent tests.
+	t.Cleanup(func() {


i actually removed port-forward from cleanup to avoid the resource leak. The test now uses its own dynamic port with defer pf.Close(), just like TestHTTPRouteNotSkippedAfterRouterRestart test

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

+	defer pf.Close()
+
+	restartedRouterURL := fmt.Sprintf("http://127.0.0.1:%s/v1/chat/completions", restartedRouterPort)
+	restartedMetricsURL := fmt.Sprintf("http://127.0.0.1:%s/metrics", restartedRouterPort)
+
+	// Verify routing works after config update and restart.
+	t.Run("VerifyUpdatedConfig", func(t *testing.T) {
+		resp := utils.CheckChatCompletionsWithURL(t, restartedRouterURL, modelRoute.Spec.ModelName, messages)
+		assert.Equal(t, 200, resp.StatusCode, "Routing should work after config update and restart")
+	})
+
+	// Verify the updated config took effect by checking scheduler plugin metrics.
+	// After restart, only the configured score plugins should appear in metrics.


+	preRestartPods := getRouterPods(t, testCtx.KubeClient, kthenaNamespace)
+	preRestartPodNames := make(map[string]bool, len(preRestartPods))
+	for _, pod := range preRestartPods {
+		preRestartPodNames[pod.Name] = true
+	}


Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

katara-Jayprakash · 2026-05-09T05:33:20Z

/cc @YaoZengzeng @hzxuzhonghu @LiZhenCheng9527 test are passing and everything is fixed now can we merge it now!

YaoZengzeng · 2026-05-09T08:13:37Z

/lgtm
/approve

volcano-sh-bot · 2026-05-09T08:13:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YaoZengzeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [YaoZengzeng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI review requested due to automatic review settings April 24, 2026 15:49

volcano-sh-bot requested review from YaoZengzeng and hzxuzhonghu April 24, 2026 15:49

volcano-sh-bot added the size/L label Apr 24, 2026

gemini-code-assist Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread test/e2e/router/shared.go Outdated

Comment thread test/e2e/router/shared.go Outdated

Comment thread test/e2e/router/shared.go

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Comment thread test/e2e/router/shared.go

Comment thread test/e2e/router/shared.go Outdated

Comment thread test/e2e/router/shared.go Outdated

Comment thread test/e2e/router/shared.go

Copilot started reviewing on behalf of katara-Jayprakash April 24, 2026 16:21 View session

volcano-sh-bot assigned YaoZengzeng Apr 27, 2026

YaoZengzeng reviewed May 8, 2026

View reviewed changes

Comment thread test/e2e/router/shared.go Outdated

Copilot AI review requested due to automatic review settings May 9, 2026 03:31

Copilot started reviewing on behalf of katara-Jayprakash May 9, 2026 03:32 View session

katara-Jayprakash force-pushed the e2e-test-for-router-config branch from f9d6c19 to 9b90e91 Compare May 9, 2026 03:33

katara-Jayprakash commented May 9, 2026

View reviewed changes

Copilot AI reviewed May 9, 2026

View reviewed changes

katara-Jayprakash force-pushed the e2e-test-for-router-config branch from 9b90e91 to f9d6c19 Compare May 9, 2026 03:47

katara-Jayprakash requested a review from YaoZengzeng May 9, 2026 03:47

katara-Jayprakash added 6 commits May 9, 2026 09:56

feat: Add router config-update e2e

bbd27b5

Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

ref: fixing linting

e31dc03

Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

ref: suggesting gemini-bot

d024404

Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

add config-update test to Gateway-inference-extension

1ad1e00

Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

fix: use constants for plugin names

bcf542b

Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

fix: refactor code according to volcano-sh#940

0bd609a

Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

Copilot AI review requested due to automatic review settings May 9, 2026 04:49

katara-Jayprakash force-pushed the e2e-test-for-router-config branch from f9d6c19 to 0bd609a Compare May 9, 2026 04:49

Copilot started reviewing on behalf of katara-Jayprakash May 9, 2026 04:50 View session

Copilot AI reviewed May 9, 2026

View reviewed changes

Comment thread test/e2e/router/shared.go

Comment thread test/e2e/router/e2e_test.go

Comment thread test/e2e/router/gateway-api/e2e_test.go

Comment thread test/e2e/router/shared.go

fix: test-e2e strictly isolate port-forward in TestRouterConfigUpdate

4debb2c

Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

volcano-sh-bot added the lgtm label May 9, 2026

volcano-sh-bot added the approved label May 9, 2026

volcano-sh-bot merged commit f5927c1 into volcano-sh:main May 9, 2026
17 checks passed

Conversation

katara-Jayprakash commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

katara-Jayprakash commented Apr 25, 2026

Uh oh!

hzxuzhonghu commented Apr 27, 2026

Uh oh!

Uh oh!

YaoZengzeng commented May 8, 2026

Uh oh!

katara-Jayprakash May 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

katara-Jayprakash commented May 9, 2026

Uh oh!

YaoZengzeng commented May 9, 2026

Uh oh!

volcano-sh-bot commented May 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

katara-Jayprakash commented Apr 24, 2026 •

edited

Loading