Skip to content

feat(embedder): minimax embeding#624

Open
zhougit86 wants to merge 2 commits intovolcengine:mainfrom
zhougit86:feature/add_minimax_embeding
Open

feat(embedder): minimax embeding#624
zhougit86 wants to merge 2 commits intovolcengine:mainfrom
zhougit86:feature/add_minimax_embeding

Conversation

@zhougit86
Copy link
Contributor

Description

enable minimax embeding

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

-add a new type of embedding provided by minimax

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


xiaogang.zhou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zhougit86 zhougit86 force-pushed the feature/add_minimax_embeding branch from 48185e0 to 2359fb8 Compare March 15, 2026 07:54
@zhougit86 zhougit86 changed the title Feature/add minimax embeding feat: minimax embeding Mar 15, 2026
@zhougit86 zhougit86 changed the title feat: minimax embeding feat(Embedder): minimax embeding Mar 15, 2026
@zhougit86 zhougit86 changed the title feat(Embedder): minimax embeding feat(embedder): minimax embeding Mar 15, 2026
region: Optional[str] = Field(default=None, description="Region for VikingDB API")
host: Optional[str] = Field(default=None, description="Host for VikingDB API")
group_id: Optional[str] = Field(default=None, description="Group ID for MiniMax API")
type: Optional[str] = Field(default="db", description="Usage type for MiniMax API: 'db' or 'query'")
Copy link
Collaborator

@ZaynJarvis ZaynJarvis Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. reference feat(embedder): add non-symmetric embedding support for query/document #608, type should be scenario specific, not a config.
  2. group_id is not a common conf, should not be in base config. I'm thinking setting it in ENVVAR as a provider specific conf. (@qin-ctx what's our suggested method for non-common config value? this also happens in feat(embedding): add Voyage text embedding support #614 output_dtype)

@ZaynJarvis
Copy link
Collaborator

if groupid and type is optional.

  1. remove these two for now
  2. fix merge conflict

then this feat can be merged.

embedding type should be discussed more

@ZaynJarvis
Copy link
Collaborator

pls update according to merged #608, reference the place to use task, and consider removing group_id for now

@zhougit86 zhougit86 force-pushed the feature/add_minimax_embeding branch from 2359fb8 to d085dea Compare March 18, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants