fix: migrate langchain shim imports to langchain_core - #254
Open
functionxX wants to merge 1 commit into
Open
Conversation
Author
|
Hi — friendly ping on this. It fixes the langchain 1.x import crash (shim re-exports removed) across the 4 affected modules, verified with py_compile + import smoke + ruff. Would appreciate a review when you have a moment. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226
What changed
After the langchain 1.x restructure removed its re-export shims,
from langchain.prompts.chat import .../from langchain.schema... import ...break withModuleNotFoundError: No module named 'langchain.prompts'. This migrates the affected imports tolangchain_core, which is already a declared dependency (pyproject.toml) and already used elsewhere in the codebase (arkitect/core/component/llm/base.py,arkitect/core/component/output_parser/rag_output.py).arkitect/core/component/prompts/custom_prompt.py—langchain.prompts.chat→langchain_core.prompts.chat,langchain.schema.messages→langchain_core.messagesarkitect/core/component/llm/llm.py—langchain.prompts.chat→langchain_core.prompts.chat,langchain.schema.output_parser→langchain_core.output_parsersarkitect/core/component/llm/utils.py—langchain.prompts.chat→langchain_core.prompts.chatdemohouse/live_voice_call/backend/prompt.py—langchain.prompts.chat→langchain_core.prompts.chatHow verified
py_compileon all four filesuv sync: all four modules import cleanlyruff check --select Iclean on the touched files (the remaining E501 warnings are pre-existing on main)