fix(demohouse/skill-validation): accept CRLF frontmatter - #259
Open
dajiaohuang wants to merge 1 commit into
Open
fix(demohouse/skill-validation): accept CRLF frontmatter#259dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #258.
Verification
npm run release:verifyindemohouse/car-decision-assistant(lint, typecheck, build, 115 tests, release validation, skill validation, isolated installer test)npm run release:validateindemohouse/sales-intelligence-workbenchnpm run skill:validateindemohouse/sales-intelligence-workbenchgit diff --checkThe broader sales backend verifier remains blocked on this Windows/Node.js 24 environment by its existing
spawnSync npm.cmd EINVALbehavior; it reaches that step only after the patched skill validation passes.