Skip to content

fix(demohouse/skill-validation): accept CRLF frontmatter - #259

Open
dajiaohuang wants to merge 1 commit into
volcengine:mainfrom
dajiaohuang:fix/windows-skill-validator-line-endings
Open

fix(demohouse/skill-validation): accept CRLF frontmatter#259
dajiaohuang wants to merge 1 commit into
volcengine:mainfrom
dajiaohuang:fix/windows-skill-validator-line-endings

Conversation

@dajiaohuang

Copy link
Copy Markdown

Summary

  • allow the car decision assistant skill validator to read CRLF frontmatter
  • apply the same line-ending handling to the sales intelligence workbench validator
  • preserve the existing LF-only behavior while making native validation portable to Windows checkouts

Fixes #258.

Verification

  • npm run release:verify in demohouse/car-decision-assistant (lint, typecheck, build, 115 tests, release validation, skill validation, isolated installer test)
  • npm run release:validate in demohouse/sales-intelligence-workbench
  • npm run skill:validate in demohouse/sales-intelligence-workbench
  • byte-level regression check against both LF Git blobs and CRLF working-tree files
  • git diff --check

The broader sales backend verifier remains blocked on this Windows/Node.js 24 environment by its existing spawnSync npm.cmd EINVAL behavior; it reaches that step only after the patched skill validation passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: skill validators reject CRLF checkouts on Windows

1 participant