This repository was archived by the owner on Sep 1, 2026. It is now read-only.
Repository navigation
Release v1.15.0 - #41
Merged
Merged
Conversation
vondravl
marked this pull request as ready for review
June 18, 2026 12:18
vondravl
force-pushed
the
feature/v1.15.0
branch
from
June 18, 2026 13:23
08e9f46 to
77bce81
Compare
….15.0) Let queries tell an active attribute filter (constrains the result — e.g. a positiveAttributeFilter locked to ['10000']) from a no-op placeholder (e.g. a negativeAttributeFilter with empty notIn, which filters nothing). - New visualizations_filters table: one row per attribute filter, keyed (visualization_id, workspace_id, filter_index). Columns: display_form_id, object_type, filter_type (positive/negative), element_count, elements (JSON). A positive and a negative filter on the same attribute stay distinct rows — unlike visualizations_references, which collapses them to one reference edge. Mirrors filter_context_fields. Element extraction covers in/notIn and values/uris formats. - New process_visualizations_filters function, wired into the export pipeline. - v_visualizations_filters view (joined to the visualization title + url_link). - v_visualizations_references gains filter_active (1/0/NULL): a per-attribute "is it actively filtered" flag that ORs over all filters on the attribute, with the detail in visualizations_filters. Also exposes url_link. - visualizations_references keeps only the filter existence edge (no lossy per-filter count bolted onto the deduped reference row). Version bump to 1.15.0, CHANGELOG and CLAUDE.md updated. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vondravl
force-pushed
the
feature/v1.15.0
branch
from
June 18, 2026 13:25
77bce81 to
7e58dc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets queries tell an active attribute filter on a visualization (constrains the result — e.g. a
positiveAttributeFilterlocked to['10000']) from a no-op placeholder (e.g. anegativeAttributeFilterwith emptynotIn, which filters nothing).Changes
visualizations_filterstable — one row per attribute filter, keyed(visualization_id, workspace_id, filter_index). Columns:display_form_id,object_type,filter_type(positive/negative),element_count,elements(JSON array of selected values/uris). A positive and a negative filter on the same attribute stay distinct rows — unlikevisualizations_references, which collapses them to one reference edge. Mirrors the existingfilter_context_fieldstable for dashboard filter contexts. Element extraction covers bothin/notInand bothvalues/urisformats; non-ASCII members (e.g.€1000) are kept readable, not\u-escaped.v_visualizations_filtersview — joined to the visualization title +url_link.filter_activeonv_visualizations_references— a1/0/NULLper-attribute flag ("is it actively filtered"), ORing over all filters on the attribute; detail lives invisualizations_filters. View also gainsurl_link.visualizations_referenceskeeps only the filter existence edge (no lossy per-filter count bolted onto the deduped row).Design notes
visualizations_references: a filter has identity (direction + selected values); forcing that onto a deduped reference edge was lossy — a positive + negative filter on one attribute collapsed to a single row whose count depended on array order. The table keeps them distinct;filter_activerecovers the at-a-glance verdict.0vsNULL:NULL= "not a filter row / doesn't apply";0= "filtered, but selects nothing". Kept distinct soelement_count = 0cleanly finds no-op placeholders.elementsas JSON: "which vizzes are locked to member X?" needsjson_each/LIKE. A normalized child table is the follow-up if direct joins on values become needed.Testing
pytest— 213 passedruff check/ruff format— cleanfilter_active,url_linkpopulated,€members readable.🤖 Generated with Claude Code