This repository was archived by the owner on Sep 1, 2026. It is now read-only.
Repository navigation
Release v1.16.0 - #42
Merged
Merged
Conversation
Add dashboards_filters table and v_dashboards_filters view to capture per-dashboard filter visibility (mode: hidden/readwrite/readonly), which dashboards_references could not represent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Constrain the filter_title/display_form_id scalar subqueries by filter_type and skip the empty local_identifier of the common date filter, so a date row can't resolve to an unrelated attribute filter (or any unkeyed '' filter). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
dashboards_filters— a per-dashboard filter-config overlay that captures each filter's visibility (mode), whichdashboards_referencescould not represent.Why
dashboards_referencescould tell you a filter was present on a dashboard, but a hidden filter looked identical to a visible one — and a hidden filter with nodisplayAsLabelleft no reference row at all (references only emit a row when an object id is referenced). Visibility is an attribute of the filter config itself, so it needs its own home.What's added
dashboards_filterstable — one row per filter config fromattributeFilterConfigs[], the commondateFilterConfig, anddateFilterConfigs[], keyed bylocal_identifier(joinsfilter_context_fields.local_identifier). Columns:mode(hidden/readwrite/readonly; NULL = default, visible),filter_type(attribute/date),tab_id,display_as_label_id,date_dataset_id. Covers both attribute and date filter visibility.v_dashboards_filtersview — dashboard title + derivedfilter_visibleflag (0 only whenmode='hidden'), withfilter_title/display_form_idresolved from the filter context via scalar subqueries (no fan-out).Design note
Mirrors the existing
visualizations_filters↔visualizations_referencessplit: keep the reference graph clean, put filter detail in a dedicated table.Verification
filter_visible=0and filter titles resolve from the context🤖 Generated with Claude Code