This repository was archived by the owner on Sep 1, 2026. It is now read-only.
Repository navigation
feat: ranking/measure-value filter detail + dangling-ref detection - #44
Merged
Merged
Conversation
visualizations_filters now records rankingFilter (operator/value/strict) and measureValueFilter (condition type/operator/value) as structured rows instead of leaving them buried in the raw content JSON. Dangling rankingFilter/measureValueFilter targets are flagged in visualizations_references (mirroring sort_invalid) instead of being silently dropped, and surfaced via the new v_visualizations_invalid_filters view. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visualizations_filtersnow capturesrankingFilterandmeasureValueFilteras structured rows, including ranking operator/value/strictness and measure-value condition details.visualizations_referencesasrankingFilter_invalid/measureValueFilter_invalid, surfaced through the newv_visualizations_invalid_filtersview, and included in local-modevisualizations.is_valid = 0.measure.localIdentifierand pluralmeasures[0].localIdentifier, with defensive handling for malformed payloads.referenced_metric_id.visualizations_filtersprimary key now includesfilter_type, andv_visualizations_filters.referenced_metric_idskips unnecessary lookups for attribute-filter rows.Test plan
uv run pytest -q(240 passed)uv run ruff check .uv run ruff format --check .git diff --check