Skip to content
This repository was archived by the owner on Sep 1, 2026. It is now read-only.

feat: ranking/measure-value filter detail + dangling-ref detection - #44

Merged
vondravl merged 1 commit into
mainfrom
feature/v1.17.0
Jul 7, 2026
Merged

vondravl merged 1 commit into
mainfrom
feature/v1.17.0

Conversation

@vondravl

@vondravl vondravl commented Jul 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • visualizations_filters now captures rankingFilter and measureValueFilter as structured rows, including ranking operator/value/strictness and measure-value condition details.
  • Dangling ranking/measure-value targets are now flagged in visualizations_references as rankingFilter_invalid / measureValueFilter_invalid, surfaced through the new v_visualizations_invalid_filters view, and included in local-mode visualizations.is_valid = 0.
  • Measure refs are extracted consistently from both measure.localIdentifier and plural measures[0].localIdentifier, with defensive handling for malformed payloads.
  • Ranking/measure-value targets resolve against bucket measures only, so attribute localIdentifiers no longer masquerade as referenced_metric_id.
  • Hardened storage/view behavior: visualizations_filters primary key now includes filter_type, and v_visualizations_filters.referenced_metric_id skips unnecessary lookups for attribute-filter rows.
  • Reduced duplication with shared filter-row construction and shared localIdentifier target handling for sorts and filters.
  • Version bumped 1.16.1 -> 1.17.0.

Test plan

  • uv run pytest -q (240 passed)
  • uv run ruff check .
  • uv run ruff format --check .
  • git diff --check
  • Secret scan clean
  • Verified end-to-end table creation, inserts, and invalid-filter view coverage through regression tests

visualizations_filters now records rankingFilter (operator/value/strict)
and measureValueFilter (condition type/operator/value) as structured
rows instead of leaving them buried in the raw content JSON. Dangling
rankingFilter/measureValueFilter targets are flagged in
visualizations_references (mirroring sort_invalid) instead of being
silently dropped, and surfaced via the new v_visualizations_invalid_filters
view.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vondravl
vondravl marked this pull request as ready for review July 7, 2026 14:13
@vondravl
vondravl merged commit 22cbd24 into main Jul 7, 2026
1 check passed
@vondravl
vondravl deleted the feature/v1.17.0 branch July 7, 2026 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant