Skip to content
This repository was archived by the owner on Sep 1, 2026. It is now read-only.

feat: not-comparable reachability views (generic, policy-free) - #45

Merged
vondravl merged 1 commit into
mainfrom
feature/v1.18.0
Aug 13, 2026
Merged

vondravl merged 1 commit into
mainfrom
feature/v1.18.0

Conversation

@vondravl

@vondravl vondravl commented Aug 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • v_objects_not_comparable — visualizations pairing a measure with a slicing attribute/date its fact dataset cannot reach in the LDM reference graph. This is the early warning for AFM "object is not comparable to X", which is a join-reachability gap rather than a broken reference (every target exists). Recursive closure over ldm_reference_sources; measures anchor via v_metrics_datasets_ancestry or a {dataset}.{fact} id split; a row is emitted only when none of a measure's fact datasets reaches the slice, which keeps multi-fact metrics from false-positiving.
  • v_dashboard_widget_date_not_comparable — the same failure at the dashboard-widget layer, where a tile binds a date via widget.dateDataSet that the insight's measures cannot reach. Invisible to the sibling view, because the binding lives on the widget rather than in the insight.
  • Both registered under category: validation, depending on v_metrics_datasets_ancestry. Plain CREATE VIEW, so there is no per-export cost until queried.
  • Deliberately policy-free: where an external conforming service (e.g. FlexConnect) computes measures, its joins are invisible to the LDM graph, so consumers filter those hits downstream via the measure_datasets column instead of this package hardcoding anyone's naming patterns.
  • Docs: CHANGELOG.md 1.18.0 entry, both views added to the CLAUDE.md Key Views table, and validation added to the documented category list (it was already used by six existing entries).
  • Unrelated CI fix, needed to go green: *.md excluded from ruff format. Ruff >= 0.16 formats Python code blocks inside Markdown, which breaks the aligned "do this / not that" examples in CLAUDE.md and README.md (a headline logger.info(...) # Not: print(...) line gets exploded across three lines). This PR is simply the first to trip it — the formatting workflow's paths filter includes pyproject.toml, so the version bump triggered it. ruff check still reads .md files not at all, so only the formatter needed excluding.
  • Same workflow: astral-sh/ruff-action v3 → v4.1.0, off deprecated Node 20 (runners were already forcing it onto Node 24). Pinned exactly, since v4+ are immutable releases with no floating v4 tag to track.

Test plan

  • pytest — 240 passed (tests/test_sql_validation.py covers the YAML wiring, SQL file existence, and dependency graph)
  • make enrich against a real export DB — confirm both views create and return plausible rows
  • Spot-check a hit by executing the visualization's AFM, and the tile under its bound date dataset

The v1.18.0 tag is auto-created by create_tag.yml on merge.

🤖 Generated with Claude Code

@vondravl
vondravl marked this pull request as ready for review August 13, 2026 13:40
v_objects_not_comparable — visualizations pairing a measure with a
slicing attribute/date its fact dataset cannot reach in the LDM
reference graph (the AFM 'object is not comparable to' early-warning),
and v_dashboard_widget_date_not_comparable — the same failure at the
dashboard-widget layer (widget.dateDataSet bindings).

Both are pure reachability over ldm_reference_sources +
v_metrics_datasets_ancestry. Deliberately policy-free: deployments that
compute some measures through an external conforming service filter
those downstream via the measure_datasets column, instead of this
package hardcoding anyone's naming patterns.

Contributed from a consumer project where these proved out as CI checks.

Also excludes *.md from ruff format: ruff >=0.16 formats Python code blocks
inside Markdown, which breaks the aligned "do this / not that" examples in
CLAUDE.md and README.md. Surfaced on this PR because the version bump to
pyproject.toml matches the formatting workflow's paths filter.

Bumps astral-sh/ruff-action v3 -> v4.1.0 to get off deprecated Node 20
(runners already force it onto Node 24). Pinned exactly because v4+ are
immutable releases, so no floating v4 tag exists to track.
@vondravl
vondravl merged commit f6dec50 into main Aug 13, 2026
1 check passed
@vondravl
vondravl deleted the feature/v1.18.0 branch August 13, 2026 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant