This repository was archived by the owner on Sep 1, 2026. It is now read-only.
Repository navigation
feat: not-comparable reachability views (generic, policy-free) - #45
Merged
Merged
Conversation
vondravl
force-pushed
the
feature/v1.18.0
branch
from
August 13, 2026 13:40
21018d9 to
ad470aa
Compare
vondravl
marked this pull request as ready for review
August 13, 2026 13:40
vondravl
force-pushed
the
feature/v1.18.0
branch
from
August 13, 2026 13:43
ad470aa to
97711c6
Compare
v_objects_not_comparable — visualizations pairing a measure with a slicing attribute/date its fact dataset cannot reach in the LDM reference graph (the AFM 'object is not comparable to' early-warning), and v_dashboard_widget_date_not_comparable — the same failure at the dashboard-widget layer (widget.dateDataSet bindings). Both are pure reachability over ldm_reference_sources + v_metrics_datasets_ancestry. Deliberately policy-free: deployments that compute some measures through an external conforming service filter those downstream via the measure_datasets column, instead of this package hardcoding anyone's naming patterns. Contributed from a consumer project where these proved out as CI checks. Also excludes *.md from ruff format: ruff >=0.16 formats Python code blocks inside Markdown, which breaks the aligned "do this / not that" examples in CLAUDE.md and README.md. Surfaced on this PR because the version bump to pyproject.toml matches the formatting workflow's paths filter. Bumps astral-sh/ruff-action v3 -> v4.1.0 to get off deprecated Node 20 (runners already force it onto Node 24). Pinned exactly because v4+ are immutable releases, so no floating v4 tag exists to track.
vondravl
force-pushed
the
feature/v1.18.0
branch
from
August 13, 2026 13:44
97711c6 to
303478b
Compare
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v_objects_not_comparable— visualizations pairing a measure with a slicing attribute/date its fact dataset cannot reach in the LDM reference graph. This is the early warning for AFM"object is not comparable to X", which is a join-reachability gap rather than a broken reference (every target exists). Recursive closure overldm_reference_sources; measures anchor viav_metrics_datasets_ancestryor a{dataset}.{fact}id split; a row is emitted only when none of a measure's fact datasets reaches the slice, which keeps multi-fact metrics from false-positiving.v_dashboard_widget_date_not_comparable— the same failure at the dashboard-widget layer, where a tile binds a date viawidget.dateDataSetthat the insight's measures cannot reach. Invisible to the sibling view, because the binding lives on the widget rather than in the insight.category: validation, depending onv_metrics_datasets_ancestry. PlainCREATE VIEW, so there is no per-export cost until queried.measure_datasetscolumn instead of this package hardcoding anyone's naming patterns.CHANGELOG.md1.18.0 entry, both views added to the CLAUDE.md Key Views table, andvalidationadded to the documentedcategorylist (it was already used by six existing entries).*.mdexcluded fromruff format. Ruff >= 0.16 formats Python code blocks inside Markdown, which breaks the aligned "do this / not that" examples inCLAUDE.mdandREADME.md(a headlinelogger.info(...) # Not: print(...)line gets exploded across three lines). This PR is simply the first to trip it — the formatting workflow'spathsfilter includespyproject.toml, so the version bump triggered it.ruff checkstill reads.mdfiles not at all, so only the formatter needed excluding.astral-sh/ruff-actionv3 → v4.1.0, off deprecated Node 20 (runners were already forcing it onto Node 24). Pinned exactly, since v4+ are immutable releases with no floatingv4tag to track.Test plan
pytest— 240 passed (tests/test_sql_validation.pycovers the YAML wiring, SQL file existence, and dependency graph)make enrichagainst a real export DB — confirm both views create and return plausible rowsThe
v1.18.0tag is auto-created bycreate_tag.ymlon merge.🤖 Generated with Claude Code