Add optional filename parameter to merlin protocol#11
Open
jonludlam wants to merge 1 commit into
Open
Conversation
- Add filename parameter to Complete_prefix, Type_enclosing, and All_errors actions - Update worker to set filename in merlin config when provided - Pass filename through to make_config and make_pipeline functions - Update merlin_client to pass None for filename in default queries This allows merlin to provide context-aware completions and type information based on the source file being edited. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (generated by Claude) adds the ability to set the filename of the source file. The goal here is to be able to use merlin in interface mode; I currently don't much care about the filename really!
I'm not convinced about the mechanism here though. I've currently added the filename as an optional param, but this might end up being a slippery slope of adding more and more. Taking a step back, it seems like the current interface is stateless, but AIUI merlin itself isn't - how do you see that evolving?