Swap to the real FastMCP and streamable-http#24
Open
M4Al wants to merge 1 commit intovoska:masterfrom
Open
Conversation
|
I think we should keep the stdio option and provide some kind of flag to expose the port. |
TheLastFrame
left a comment
TheLastFrame
left a comment
There was a problem hiding this comment.
maybe you could use an environment variable like this to keep the default behaviour, but also support standalone usage?
Comment on lines
+6
to
+7
| """Run the MCP server with treamable-http communication""" | ||
| mcp.run(transport="streamable-http", host="0.0.0.0", port=8000) |
There was a problem hiding this comment.
Suggested change
| """Run the MCP server with treamable-http communication""" | |
| mcp.run(transport="streamable-http", host="0.0.0.0", port=8000) | |
| if os.environ.get("STANDALONE", false): | |
| """Run the MCP server with streamable-http communication""" | |
| mcp.run(transport="streamable-http", host="0.0.0.0", port=8000) | |
| else: | |
| """Run the MCP server with stdio communication""" | |
| mcp.run() |
Comment on lines
+8
to
+9
| """Run the MCP server with treamable-http communication""" | ||
| mcp.run(transport="streamable-http", host="0.0.0.0", port=8000) |
There was a problem hiding this comment.
Suggested change
| """Run the MCP server with treamable-http communication""" | |
| mcp.run(transport="streamable-http", host="0.0.0.0", port=8000) | |
| if os.environ.get("STANDALONE", false): | |
| """Run the MCP server with streamable-http communication""" | |
| mcp.run(transport="streamable-http", host="0.0.0.0", port=8000) | |
| else: | |
| """Run the MCP server with stdio communication""" | |
| mcp.run() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably not what you want, but you can use this as inspiration to implement Streamable HTTP (sse compatible) for this MCP server.