Skip to content

Adding a Ruby based Puppet task that checks for which .NET versions ar… - #70

Open
jdub55 wants to merge 5 commits into
voxpupuli:masterfrom
jdub55:dotnettasks
Open

jdub55 wants to merge 5 commits into
voxpupuli:masterfrom
jdub55:dotnettasks

Conversation

@jdub55

@jdub55 jdub55 commented Sep 3, 2019

Copy link
Copy Markdown

…e installed

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@jdub55

jdub55 commented Sep 3, 2019

Copy link
Copy Markdown
Author

Cleaned up Ruby formatting warnings with Rubocop. How can I get the Travis CI checks to run again?

@jdub55

jdub55 commented Sep 3, 2019

Copy link
Copy Markdown
Author

Temporarily closing and re-opening to kick off a new build.

@jdub55 jdub55 closed this Sep 3, 2019
@jdub55 jdub55 reopened this Sep 3, 2019
Further rubocop style updates
@jdub55

jdub55 commented Sep 4, 2019

Copy link
Copy Markdown
Author

Additional updates to syntax made to pass Rubocop checks. Closing and re-opening to kick off the Travis CI jobs again.

@jdub55 jdub55 closed this Sep 4, 2019
@jdub55 jdub55 reopened this Sep 4, 2019
More Rubocop style changes.
@jdub55

jdub55 commented Sep 4, 2019

Copy link
Copy Markdown
Author

OK. Apologies for the noise with all the commits and re-opening. (Looks like I didn't need to close and re-open, just push to origin again)

The one piece I'm unsure about is documentation of the new task in the README.md. I was going to make changes but wasn't sure where the preferred place to make them would be. Any guidance there would be appreciated. Running the task is easy as invoking "bolt script run regcheck.rb" on a set of target nodes.

@@ -0,0 +1,3 @@
{
"description": "Query which .NET versions are installed on Windows Server(s)."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this limited to servers or does it work on desktops too?

@jdub55 jdub55 Sep 5, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work on all recent Windows OS versions as far as this article is concerned: https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/how-to-determine-which-versions-are-installed

@genebean

genebean commented Sep 5, 2019

Copy link
Copy Markdown

It looks to me like an update to the readme should be added to this too.

@jdub55

jdub55 commented Sep 5, 2019

Copy link
Copy Markdown
Author

It looks to me like an update to the readme should be added to this too.

@genebean agreed. I just wasn't quite sure whether to create a separate Tasks section in the Readme file or the best place to put it? So looking for some guidance from other contributors before I make any changes to it.

Added task information to Readme file
@jdub55

jdub55 commented Sep 17, 2019

Copy link
Copy Markdown
Author

Ping. Any comments on this task or what it might take to get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants