LibPinMAME: add pinball plugin support#448
Draft
vbousquet wants to merge 2 commits intovpinball:masterfrom
Draft
LibPinMAME: add pinball plugin support#448vbousquet wants to merge 2 commits intovpinball:masterfrom
vbousquet wants to merge 2 commits intovpinball:masterfrom
Conversation
263d672 to
687a9aa
Compare
39b8fba to
a302127
Compare
46cb420 to
524bae7
Compare
1dc9e23 to
cacb58a
Compare
cacb58a to
5fd45bb
Compare
2d58727 to
80c5761
Compare
f90dded to
f5091ec
Compare
5a3794f to
9205645
Compare
167601d to
d095017
Compare
- simplify API use (deviceId = legacy mapping) - fix backward compatibility regarding some invalid device ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up from #303 which purposes were to:
Since this draft PR was created, a plugin architecture was prototyped on the VPX side. This plugin architecture serves similar purpose but with a broader application range. It is organized around a simple message bus, allowing better collaboration between components. This PR replace the stateblock approach by the message bus approach used by the plugin system. Thanks to the plugin design, this PR serves the original aims with the following benefits:
This is a draft PR since the plugin design is not stable yet and will likely evolve some more, as it developped by designing the API then validating against 2 or 3 real world use cases. This validation phase is not yet finished.