Skip to content

Debug 8M element matrix#47

Draft
vqd8a wants to merge 8 commits into
developfrom
test-8M_elem_cond
Draft

Debug 8M element matrix#47
vqd8a wants to merge 8 commits into
developfrom
test-8M_elem_cond

Conversation

@vqd8a
Copy link
Copy Markdown
Owner

@vqd8a vqd8a commented Nov 17, 2025

@trilinos/

Motivation

Related Issues

  • Closes put-issue-number-here

Stakeholder Feedback

Testing

Signed-off-by: Vinh Dang <vqdang@sandia.gov>
@github-actions
Copy link
Copy Markdown

CDash for AT1 results [Only accessible from Sandia networks]
CDash for AT2 results [Currently only accessible from Sandia networks]

@github-actions
Copy link
Copy Markdown

Your PR updated files that did not respect package formatting settings.
Please apply the patch given below. Alternatively you can download a patch file here.

Patch
diff --git a/packages/ifpack2/src/Ifpack2_IlukGraph.hpp b/packages/ifpack2/src/Ifpack2_IlukGraph.hpp
index d1923784..a303b58f 100644
--- a/packages/ifpack2/src/Ifpack2_IlukGraph.hpp
+++ b/packages/ifpack2/src/Ifpack2_IlukGraph.hpp
@@ -542,8 +542,8 @@ void IlukGraph<GraphType, KKHandleType>::initialize(const Teuchos::RCP<KKHandleT
   auto localOverlapGraph = OverlapGraph_->getLocalGraphDevice();
 
   // VINH TEST
-  //int myRank;
-  //MPI_Comm_rank (MPI_COMM_WORLD, &myRank);
+  // int myRank;
+  // MPI_Comm_rank (MPI_COMM_WORLD, &myRank);
   // END VINH TEST
 
   if (KernelHandle->get_spiluk_handle()->get_nrows() < static_cast<size_type>(NumMyRows)) {
@@ -553,7 +553,7 @@ void IlukGraph<GraphType, KKHandleType>::initialize(const Teuchos::RCP<KKHandleT
   }
 
   // VINH TEST
-  //fprintf(stderr, "IlukGraph<GraphType, KKHandleType>::initialize () BeFore symbolic, rank %d, NumMyRows %d, num L entries %d, num U entries %d, Overalloc_ %lf\n",
+  // fprintf(stderr, "IlukGraph<GraphType, KKHandleType>::initialize () BeFore symbolic, rank %d, NumMyRows %d, num L entries %d, num U entries %d, Overalloc_ %lf\n",
   //        myRank, NumMyRows, KernelHandle->get_spiluk_handle()->get_nnzL(), KernelHandle->get_spiluk_handle()->get_nnzU(), Overalloc_);
   // END VINH TEST
 
@@ -575,7 +575,7 @@ void IlukGraph<GraphType, KKHandleType>::initialize(const Teuchos::RCP<KKHandleT
       data_type nnzU = static_cast<data_type>(Overalloc_) * U_entries.extent(0);
       KernelHandle->get_spiluk_handle()->reset_handle(NumMyRows, nnzL, nnzU);
       // VINH TEST
-      //fprintf(stderr, "IlukGraph<GraphType, KKHandleType>::initialize () symbolic caught error, rank %d, NumMyRows %d, num L entries %d, num U entries %d, Overalloc_ %lf\n",
+      // fprintf(stderr, "IlukGraph<GraphType, KKHandleType>::initialize () symbolic caught error, rank %d, NumMyRows %d, num L entries %d, num U entries %d, Overalloc_ %lf\n",
       //        myRank, NumMyRows, KernelHandle->get_spiluk_handle()->get_nnzL(), KernelHandle->get_spiluk_handle()->get_nnzU(), Overalloc_);
       // END VINH TEST
       Kokkos::resize(L_entries, KernelHandle->get_spiluk_handle()->get_nnzL());
@@ -589,7 +589,7 @@ void IlukGraph<GraphType, KKHandleType>::initialize(const Teuchos::RCP<KKHandleT
   } while (symbolicError);
 
   // VINH TEST
-  //fprintf(stderr, "IlukGraph<GraphType, KKHandleType>::initialize () AfTer symbolic, rank %d, NumMyRows %d, num L entries %d, num U entries %d\n",
+  // fprintf(stderr, "IlukGraph<GraphType, KKHandleType>::initialize () AfTer symbolic, rank %d, NumMyRows %d, num L entries %d, num U entries %d\n",
   //        myRank, NumMyRows, KernelHandle->get_spiluk_handle()->get_nnzL(), KernelHandle->get_spiluk_handle()->get_nnzU());
   // END VINH TEST
 
diff --git a/packages/ifpack2/src/Ifpack2_RILUK_def.hpp b/packages/ifpack2/src/Ifpack2_RILUK_def.hpp
index 166ae290..bcb0e484 100644
--- a/packages/ifpack2/src/Ifpack2_RILUK_def.hpp
+++ b/packages/ifpack2/src/Ifpack2_RILUK_def.hpp
@@ -493,8 +493,8 @@ void RILUK<MatrixType>::initialize() {
 
   // VINH TEST
   int myRank, nRanks;
-  MPI_Comm_rank (MPI_COMM_WORLD, &myRank);
-  MPI_Comm_size (MPI_COMM_WORLD, &nRanks);
+  MPI_Comm_rank(MPI_COMM_WORLD, &myRank);
+  MPI_Comm_size(MPI_COMM_WORLD, &nRanks);
   // END VINH TEST
   Teuchos::Time timer("RILUK::initialize");
   double startTime = timer.wallTime();
@@ -568,11 +568,11 @@ void RILUK<MatrixType>::initialize() {
         A_local_crs_ = rcp_const_cast<const crs_matrix_type>(A_local_crs_nc_);
       }
       if (!isKokkosKernelsStream_) {
-        {// VINH TEST
-          //auto lclMtx = A_local_crs_->getLocalMatrixDevice();      
-          //std::string fnA_mtx = "A_r_" + std::to_string( myRank ) + ".mtx";
-          //KokkosSparse::Impl::write_kokkos_crst_matrix<local_matrix_device_type>(lclMtx, fnA_mtx.c_str());
-        }// VINH TEST
+        {  // VINH TEST
+           // auto lclMtx = A_local_crs_->getLocalMatrixDevice();
+           // std::string fnA_mtx = "A_r_" + std::to_string( myRank ) + ".mtx";
+           // KokkosSparse::Impl::write_kokkos_crst_matrix<local_matrix_device_type>(lclMtx, fnA_mtx.c_str());
+        }  // VINH TEST
         Graph_ = rcp(new Ifpack2::IlukGraph<crs_graph_type, kk_handle_type>(A_local_crs_->getCrsGraph(),
                                                                             LevelOfFill_, 0, Overalloc_));
       } else {
@@ -637,7 +637,7 @@ void RILUK<MatrixType>::initialize() {
     }
 
     // VINH TEST
-    //fprintf(stderr, "RILUK<MatrixType>::initialize (), rank %d, BEFORE create_spiluk_handle and spiluk_symbolic, LevelOfFill_ %d\n", myRank, LevelOfFill_);
+    // fprintf(stderr, "RILUK<MatrixType>::initialize (), rank %d, BEFORE create_spiluk_handle and spiluk_symbolic, LevelOfFill_ %d\n", myRank, LevelOfFill_);
     // END VINH TEST
     if (this->isKokkosKernelsSpiluk_) {
       if (!isKokkosKernelsStream_) {
@@ -662,7 +662,7 @@ void RILUK<MatrixType>::initialize() {
       Graph_->initialize();
     }
     // VINH TEST
-    //fprintf(stderr, "RILUK<MatrixType>::initialize (), rank %d, AFTER create_spiluk_handle and spiluk_symbolic\n", myRank);
+    // fprintf(stderr, "RILUK<MatrixType>::initialize (), rank %d, AFTER create_spiluk_handle and spiluk_symbolic\n", myRank);
     // END VINH TEST
 
     allocate_L_and_U();

More details about our use of clang-format and other tools can be found in the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant