Addressed community review comment - Moved dhcpv4 flag from FEATURE table to DEVICE_METADATA table - DHCPv4#5
Open
vasanth2-cisco wants to merge 2 commits into
Open
Conversation
…able to DEVICE_METADATA table
vasanth2-cisco
requested review from
Subhasri-Ramasamy,
ksandeep-palc and
vrajeshe
cshivashgit
approved these changes
Sep 23, 2025
vasanth2-cisco
force-pushed
the
palc/db_migrator_update
branch
from
9672b47 to
f492c18
Compare
vasanth2-cisco
force-pushed
the
palc/db_migrator_update
branch
from
f492c18 to
59b82c1
Compare
skulambi-cisco
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed community review comment:
Moved "has_sonic_dhcpv4_relay" flag from FEATURE["dhcp_relay"] to DEVICE_METADATA["localhost"] table
sonic-net/sonic-dhcp-relay#67
spytest logs:
26700_dhcpv4_new_design_logs.zip
ISC_26700_logs.zip
db_migration_reboot_logs.odt
DB_migrator Coverage: