ci: verify master after a merge - #179
Merged
Merged
Conversation
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Visual Changes: 8 of 8 screenshots changed 📸 contacts desktop — 100% changed📸 contacts mobile — 100% changed📸 home desktop — 100% changed📸 home mobile — 100% changed📸 interests desktop — 100% changed📸 interests mobile — 100% changed📸 projects desktop — 100% changed📸 projects mobile — 100% changedReady to merge! ✨ 🔗 View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing verified
masterafter a merge - this repo ranpr-validation.ymlonly, so the first sign master was broken was a deploy.Adds a separate minimal
ci.ymlonpush: masterrunningnpm run verify+format:check.Deliberately not merged into
pr-validation.yml. I originally proposed oneci.ymlper repo, and that is wrong here: this repo's PR validation does PR-specific work - visual diff against the base branch, screenshots keyed by PR number, PR comments - which is meaningless on master. One file per role only holds when the roles are actually the same.