Migrate ADC to new 5.x driver - #473
Merged
Merged
Conversation
Owner
Author
|
@martinberlin If you have the time and a V5 board handy, could you test this change? |
Collaborator
|
Looking good. This is my Serial output testing with dragon in a 6" board: |
Owner
Author
|
The dragon example doesn't actually read from ADC, afaik. Can you try again with the demo example? |
Collaborator
|
I can but I'm afraid that is a V6 board not a V5. Actually after my move to Barcelona I don't really know where is my v5 board :( |
Owner
Author
|
Ok, then I can test in May when I'm back home. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since IDF 4.x support is dropped, we can migrate to the new ADC driver.
This was extracted from #463 by @Bwooce.