Repository navigation
Allow host-selected internal storage events to bypass normal-file target regex - #233
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change keeps ordinary-file allow-lists (
syncOnlyRegEx) from blocking optional internal synchronisation (i:andix:) and host-selected internal storage events.Behaviour
EntryManager.isTargetFileexempts internal documents (i:andix:) and explicitinternalFileEventchecks fromsyncOnlyRegEx, while preservingignoreRegExoni:documents for backward compatibility and continuing to exemptix:documents from both normal-file patterns.StorageEventManagerBaseaccepts an optionalisTargetInternalFiledependency forINTERNALstorage events, preserving protected-path exclusions (shouldBeIgnored) and existing host admission when not supplied.IVaultService.isTargetFileforwardsoptions.internalFileEventtoisAcceptedByLocalDBFactoryso a host can run veto handlers on internal file events without requiring ordinary-file eligibility.Verification
npm run check:types,npx vitest run(212 files, 4,198 tests),npm run build:package,npm run test:boundary,npm run check:boundary, andnpm run test:packagepassed.npm run checkand 2,530 unit tests).Refs vrtmrz/obsidian-livesync#825.